Refactor queue submission to resolve a hang (#377) #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when fast kernel relaunching many dependent events in a row. This removes a circular dependence and recursion between acl_command_queue and acl_device_op and thus makes the code much simpler to reason about. All commands are now submitted by the acl_update_*_queue functions.
sophimao
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when fast kernel relaunching many dependent events in a row.
This removes a circular dependence and recursion between acl_command_queue and acl_device_op and thus makes the code much simpler to reason about. All commands are now submitted by the acl_update_*_queue functions.
This is a cherry-pick from main.