Load libz.so.1 #69
Merged
Load libz.so.1 #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zibaiwan
requested changes
Feb 2, 2022
There was a problem hiding this comment.
@alisanikiforova, thanks for fixing this. Can you please squash those two commits into one commit and make the commit message structured like Title + Content? Thanks! Let me know if you need any help with squashing the commits. I usually use git reset --soft HEAD~2 && git commit and you probably need to push with force. You can also use git rebase -i.
alisanikiforova
force-pushed
the
zlib_fix
branch
from
39215e9 to
ecb4d2e
Compare
zibaiwan
previously approved these changes
Feb 2, 2022
pcolberg
suggested changes
Feb 2, 2022
There was a problem hiding this comment.
Thanks @alisanikiforova! Just a few minor cosmetic suggestions:
Some supported OSs only contain libz.so.1, which dlopen fails to find causing our compiles to fail because the packager editor library is used during compile. This change ensures ew check for botrh libz.so.1 and libz.so beofre freaking out and saying libz isn't installed.
alisanikiforova
force-pushed
the
zlib_fix
branch
from
ecb4d2e to
64446e5
Compare
pcolberg
approved these changes
Feb 2, 2022
zibaiwan
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many OSs have only libz.so.1 but no libz.so, so when loading zlib, want to check both and load libz.so.1 first, and then double check libz.so if that fails.