Skip to content

Fix TSAN data races #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Fix TSAN data races #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions test/acl_command_queue_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,6 @@ MT_TEST(acl_command_queue, create_with_properties) {
CHECK_EQUAL(CL_SUCCESS, clReleaseCommandQueue(cq));
CHECK_EQUAL(1, acl_ref_count(cq));
CHECK_EQUAL(CL_SUCCESS, clReleaseCommandQueue(cq));
CHECK_EQUAL(0, acl_ref_count(cq));
ACL_LOCKED(CHECK(!acl_command_queue_is_valid(cq)));

// wait until all threads do their checks on the 0-ref-count command
// queue before starting the next iteration of the loop and creating new
Expand Down Expand Up @@ -421,8 +419,6 @@ MT_TEST(acl_command_queue, create_with_properties) {
CHECK_EQUAL(CL_SUCCESS, clReleaseCommandQueue(cq));
CHECK_EQUAL(1, acl_ref_count(cq));
CHECK_EQUAL(CL_SUCCESS, clReleaseCommandQueue(cq));
CHECK_EQUAL(0, acl_ref_count(cq));
ACL_LOCKED(CHECK(!acl_command_queue_is_valid(cq)));

// wait until all threads do their checks on the 0-ref-count command
// queue before starting the next iteration of the loop and creating new
Expand Down Expand Up @@ -674,15 +670,6 @@ MT_TEST(acl_command_queue, after_context_release) {
// Should be able to release all the way.
CHECK_EQUAL(CL_SUCCESS, clReleaseCommandQueue(cq0));
CHECK_EQUAL(CL_SUCCESS, clReleaseCommandQueue(cq1));
CHECK_EQUAL(0, acl_ref_count(cq0));
CHECK_EQUAL(0, acl_ref_count(cq1));

ACL_LOCKED(CHECK(!acl_command_queue_is_valid(cq0)));
ACL_LOCKED(CHECK(!acl_command_queue_is_valid(cq1)));

// And once it's gone, it's gone.
CHECK_EQUAL(CL_INVALID_COMMAND_QUEUE, clReleaseCommandQueue(cq0));
CHECK_EQUAL(CL_INVALID_COMMAND_QUEUE, clReleaseCommandQueue(cq1));
}

// Main Event is in an OOO queue. It has a dependent event in an in-order queue.
Expand Down