Skip to content

Fix GCC warning: ignoring #pragma warning #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Fix GCC warning: ignoring #pragma warning #83

merged 2 commits into from
Feb 22, 2022

Conversation

pcolberg
Copy link
Contributor

@pcolberg pcolberg commented Feb 18, 2022

Guard suppression of MVSC unreferenced formal parameter warning.

#ifdef _MSC_VER
#pragma warning(push)
#pragma warning(disable : 4100) // unreferenced formal parameter
#endif
#include <CppUTest/TestHarness.h>
#ifdef _MSC_VER
#pragma warning(pop)
#endif

Prerequisite of #85

Guard suppression of MVSC unreferenced formal parameter warning.

https://github.com/intel/fpga-runtime-for-opencl/blob/aca879be71ca8f7e06a9d5bafbe5c79820bb9a3d/test/acl_command_queue_test.cpp#L4-L11

[92/113] Building CXX object test/CMakeFiles/acl_test.dir/acl_svm_test.cpp.o
../test/acl_svm_test.cpp:4:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning(push, 0)

../test/acl_svm_test.cpp:6:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning(pop);
Guard suppression of MVSC unreferenced formal parameter warning.

https://github.com/intel/fpga-runtime-for-opencl/blob/aca879be71ca8f7e06a9d5bafbe5c79820bb9a3d/test/acl_command_queue_test.cpp#L4-L11

[106/113] Building CXX object test/CMakeFiles/acl_test.dir/acl_usm_test.cpp.o
../test/acl_usm_test.cpp:8:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning(push, 0)

../test/acl_usm_test.cpp:10:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning(pop);
@pcolberg pcolberg added this to the 2022.3 milestone Feb 18, 2022
@pcolberg pcolberg self-assigned this Feb 18, 2022
@pcolberg pcolberg requested a review from zibaiwan February 18, 2022 22:25
Copy link
Contributor

@zibaiwan zibaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @pcolberg !

@pcolberg pcolberg merged commit 91d9f2a into intel:main Feb 22, 2022
@pcolberg pcolberg deleted the pragma-warning branch February 22, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants