[UR][Offload] Implement UR_DEVICE_INFO_MAX_WORK_ITEM_SIZES #19275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@callumfare (or anyone in @intel/unified-runtime-reviewers , if they want) mind having a look at this? |
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
@intel/unified-runtime-reviewers Can I get this looked at? |
kbenzie
reviewed
Jul 15, 2025
Comment on lines
102
to
105
| if (isVec3) { | ||
| if (pPropSizeRet) { | ||
| *pPropSizeRet = sizeof(size_t) * 3; | ||
| } | ||
|
|
||
| if (pPropValue) { | ||
| ol_dimensions_t olVec; | ||
| size_t *urVec = reinterpret_cast<size_t *>(pPropValue); | ||
| OL_RETURN_ON_ERR(olGetDeviceInfo(hDevice->OffloadDevice, olInfo, | ||
| sizeof(olVec), &olVec)); | ||
|
|
||
| urVec[0] = olVec.x; | ||
| urVec[1] = olVec.y; | ||
| urVec[2] = olVec.z; | ||
| } | ||
|
|
||
| return UR_RESULT_SUCCESS; | ||
| } |
There was a problem hiding this comment.
Why not do this in case UR_DEVICE_INFO_MAX_WORK_ITEM_SIZES:?
There was a problem hiding this comment.
I assumed that there were more info queries that return size_t[3]... But a quick skim shows that's not the case. I'll go move this in there then.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
approved these changes
Jul 21, 2025
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@kbenzie If you're happy with the change, could you merge this please? |
kbenzie
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.