[SYCL] Use SPIR-V built-in function call for all targets and add BuiltIn to the name
#19359
+1,195
−1,813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltIn` to the name Before this PR, SPIR-V built-in is represented as global variable for SPIR/SPIR-V targets and as function call for other targets in include/sycl/__spirv/spirv_vars.hpp. According to https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/main/docs/SPIRVRepresentationInLLVM.rst, SPIR-V built-in variable can be mapped to either function call or global variable. So function call representation should work for SPIR-V target. Add `BuiltIn` to the name to align with SPIR-V friendly IR.
wenju-he
added a commit
to wenju-he/llvm-project
that referenced
this pull request
Jul 14, 2025
This fixes pre-commit CI fail in intel/llvm#19359
wenju-he
added a commit
to llvm/llvm-project
that referenced
this pull request
Jul 18, 2025
…#148567) The mapping ensures the function is lowered to SPIR-V built-in variables in SPIR-V. This can fix pre-commit CI fail in intel/llvm#19359 Also add BuiltIn to SPIR-V Builtin function name in __clang_spirv_builtins.h to align with https://github.com/llvm/llvm-project/blob/main/llvm/docs/SPIRVUsage.rst#builtin-variables
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 18, 2025
…n variables (#148567) The mapping ensures the function is lowered to SPIR-V built-in variables in SPIR-V. This can fix pre-commit CI fail in intel/llvm#19359 Also add BuiltIn to SPIR-V Builtin function name in __clang_spirv_builtins.h to align with https://github.com/llvm/llvm-project/blob/main/llvm/docs/SPIRVUsage.rst#builtin-variables
wenju-he
added a commit
to wenju-he/llvm
that referenced
this pull request
Jul 18, 2025
… (#148567) The mapping ensures the function is lowered to SPIR-V built-in variables in SPIR-V. This can fix pre-commit CI fail in intel#19359 (cherry picked from commit 64205ad) This is a partial cherry-pick since 27c9b55 isn't in intel/llvm yet.
hvdijk
reviewed
Jul 18, 2025
hvdijk
reviewed
Jul 18, 2025
hvdijk
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, SPIR-V built-in is represented as global variable for SPIR/SPIR-V targets and as function call for other targets in include/sycl/__spirv/spirv_vars.hpp.
According to https://github.com/llvm/llvm-project/blob/main/llvm/docs/SPIRVUsage.rst, SPIR-V built-in variable can be mapped to either function call or global variable. So function call representation should work for SPIR-V target.
Add
BuiltInto the name to align with SPIR-V friendly IR.