Skip to content

[NFC][SYCL] Clarify comments to TryToGet* type traits #8510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2023
Merged

[NFC][SYCL] Clarify comments to TryToGet* type traits #8510

merged 1 commit into from
Mar 8, 2023

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner March 1, 2023 20:59
@aelovikov-intel aelovikov-intel requested a review from againull March 1, 2023 20:59
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 2, 2023 03:12 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 2, 2023 09:57 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 7, 2023 23:51 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor Author

Failing

Unresolved Tests (1):
  SYCL :: AsyncHandler/default_async_handler.cpp
``` is covered by https://github.com/intel/llvm/issues/8555

AWS CUDA testing runner waiting is also known.

@intel/llvm-gatekeepers , this PR is ready.

@bader
Copy link
Contributor

bader commented Mar 8, 2023

@aelovikov-intel, I see that you run testing twice and previous run there were other failures:

  ********************
  Timed Out Tests (1):
    SYCL :: Basic/reqd_work_group_size.cpp
  
  ********************
  Failed Tests (1):
    SYCL :: AtomicRef/atomic_memory_order_acq_rel.cpp

CI checks other than clang-format-check do not test changes in this PR, so I don't see any reasons to re-run tests. The only value is exposure of existing issues in CI system.

@bader bader merged commit 6a47be0 into intel:sycl Mar 8, 2023
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 9, 2023 12:24 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel mentioned this pull request Mar 28, 2023
Closed
@aelovikov-intel aelovikov-intel deleted the clarify_comments branch April 7, 2023 15:57
@aelovikov-intel aelovikov-intel restored the clarify_comments branch April 7, 2023 15:57
@aelovikov-intel aelovikov-intel deleted the clarify_comments branch April 7, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@againull againull againull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelovikov-intel @bader @againull