Skip to content

feat: add IN | NIN predicate for custom attribute types #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2019

Conversation

igdianov
Copy link
Collaborator

@igdianov igdianov commented May 6, 2019

This PR add support for IN, NIN predicates in criteria expressions for custom attributes, i.e.

query {
  TaskVariables(where: { 
    value: {IN: [null, true, "data", 12345, 1.2345]} 
  }) {
    select {
      name
      value
    }
  }
}
query {
  TaskVariables(where: { 
    value: {NIN: true} 
  }) {
    select {
      name
      value
    }
  }
}

@igdianov igdianov self-assigned this May 6, 2019
@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #136 into master will increase coverage by 0.17%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
+ Coverage     68.49%   68.66%   +0.17%     
- Complexity      407      415       +8     
============================================
  Files            33       33              
  Lines          2079     2097      +18     
  Branches        311      317       +6     
============================================
+ Hits           1424     1440      +16     
- Misses          529      531       +2     
  Partials        126      126
Impacted Files Coverage Δ Complexity Δ
...hql/jpa/query/schema/impl/JpaPredicateBuilder.java 50.63% <77.77%> (+3.14%) 52 <4> (+8) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6359449...82bbd87. Read the comment docs.

@igdianov igdianov force-pushed the igdianov-custom-attributes-in-criterias branch from 8a0c768 to 82bbd87 Compare May 6, 2019 00:13
@igdianov igdianov merged commit ac7bda6 into master May 6, 2019
@igdianov igdianov deleted the igdianov-custom-attributes-in-criterias branch May 6, 2019 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant