Skip to content

docs(checkbox): update for new syntax, add migration guide #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 2, 2023
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 1, 2023

This PR makes the following changes:

  1. Updates existing playgrounds to v7 and uses the new checkbox syntax.
  2. Adds a migration guide for moving to the new syntax.
  3. Adds "Label Placement" and "Justification" playgrounds.

Preview: https://ionic-docs-git-fw-2942-ionic1.vercel.app/docs/v7/api/checkbox

Note: There is a height discrepancy between checkbox and radio that I am currently investigating. As a result, the checkboxes in the "Label Placement" demo may look a bit smushed for now.

@vercel
Copy link

vercel bot commented Feb 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 2, 2023 at 3:57PM (UTC)

@liamdebeasi liamdebeasi changed the title Fw 2942 docs(checkbox): update for new syntax, add migration guide Feb 1, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review February 1, 2023 17:46
@liamdebeasi liamdebeasi requested a review from a team February 1, 2023 17:46
@liamdebeasi liamdebeasi closed this Feb 1, 2023
@liamdebeasi liamdebeasi reopened this Feb 1, 2023
Co-authored-by: Amanda Johnston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants