Skip to content

refactor(utils): update slotMutationController to allow multiple slot names #28396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

averyjohnston
Copy link
Contributor

@averyjohnston averyjohnston commented Oct 23, 2023

Issue number: Internal


What is the current behavior?

The internal slotMutationController utility can only watch one slot name at a time.

What is the new behavior?

Added the option to specify multiple slot names, any of which will trigger the callback. This change is made in preparation for upcoming start and end slots for several form control components; it boosts performance by preventing us from needing to add multiple createSlotMutationController calls to each component.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Oct 23, 2023
@averyjohnston averyjohnston marked this pull request as ready for review October 23, 2023 18:18
@averyjohnston averyjohnston requested review from a team and thetaPC and removed request for a team October 23, 2023 18:41
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but this should be a refactor(util) commit since it's an internal change.

@averyjohnston
Copy link
Contributor Author

Ah, right, perf will show up in the changelog, huh 🤔 I figured refactor didn't fit since this is a behavior change (if an internal one) but it makes sense if the concern is more public API changes.

@averyjohnston averyjohnston changed the title perf(utils): update slotMutationController to allow multiple slot names refactor(utils): update slotMutationController to allow multiple slot names Oct 25, 2023
@averyjohnston averyjohnston merged commit bfad5a4 into FW-2853 Nov 27, 2023
@averyjohnston averyjohnston deleted the FW-2853-base branch November 27, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants