Fix #4451 and 4481: default in export statements
#4483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt only when it follows `export` or `as`
This was referenced Apr 9, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lexer was treating every appearance of
defaultwithin anexportstatement as thedefaultkeyword, leading to #4451. This PR treatsdefaultas a keyword in an export statement only when it followsexportoras, or is already covered by the grammar as part of anExportSpecifier, which fixes #4451.We had the ability to import a module member named
default, but notexportone. This adds that ability, fixing #4481. Tests for these cases are included.