Skip to content

Update wording of 01-Getting-Started #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Update wording of 01-Getting-Started #643

merged 1 commit into from
Dec 5, 2018

Conversation

imidom
Copy link
Contributor

@imidom imidom commented Dec 4, 2018

Hi! I'm learning Javascript and have found these tutorials to be incredibly helpful. While the articles are very clear, some of the wording isn't natural to me as an English speaker. I was hoping I could contribute to this project by updating the wording of the articles to read more like natural English. If you like these edits, let me know and I'll make my way through the rest of the articles as I read them. Thanks for creating this.

Hi! I'm learning Javascript and have found these tutorials to be incredibly helpful. While the articles are very clear, some of the wording isn't natural to me as an English speaker. I was hoping I could contribute to this project by updating the wording of the articles to read more like natural English. If you like these edits, let me know and I'll make my way through the rest of the articles as I read them. Thanks for creating this.
@CLAassistant
Copy link

CLAassistant commented Dec 4, 2018

CLA assistant check
All committers have signed the CLA.

@iliakan
Copy link
Member

iliakan commented Dec 5, 2018

Thank you!


In this aspect, JavaScript is very different from another language called [Java](https://en.wikipedia.org/wiki/Java_(programming_language)).

```smart header="Why <u>Java</u>Script?"
When JavaScript was created, it initially had another name: "LiveScript". But Java language was very popular at that time, so it was decided that positioning a new language as a "younger brother" of Java would help.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not everyone knows that Java is a language.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave it as is or add "programming language".

Copy link
Contributor Author

@imidom imidom Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! We just need to add a "The" in there-->

Suggested change
When JavaScript was created, it initially had another name: "LiveScript". But Java language was very popular at that time, so it was decided that positioning a new language as a "younger brother" of Java would help.
When JavaScript was created, it initially had another name: "LiveScript". But the Java programming language was very popular at that time, so it was decided that positioning a new language as a "younger brother" of Java would help.

@@ -86,14 +86,13 @@ There are at least *three* great things about JavaScript:
```compare
+ Full integration with HTML/CSS.
+ Simple things are done simply.
+ Supported by all major browsers and enabled by default.
+ Support by all major browsers and enabled by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look good.

Copy link
Contributor Author

@imidom imidom Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I made this change was to help the last line match the structure of the first one. The changing structure of these bullets makes them a little bit harder to follow.

If each bullet starts with a verb, they'll flow more naturally together. A quick test would be to put "Javascript is..." in front of each of these to see if they form a well-structured sentence. If each of these passes the test, we've gotten closer to the parallel structure described in the link above:

  • Fully integrated with HTML/CSS.
  • Supported by all major browsers and enabled by default.
  • Able to do simple things in simple ways.

Let me know if you would like me to make these changes or keep as is.

Copy link
Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix.

@imidom
Copy link
Contributor Author

imidom commented Dec 5, 2018

Hi @iliakan, I responded to your comments!

@iliakan
Copy link
Member

iliakan commented Dec 5, 2018

You're a native speaker, is that correct?

@imidom
Copy link
Contributor Author

imidom commented Dec 5, 2018

I am, but I do not want to make changes you don't agree with. This is a great tutorial--I want to help the wording flow more naturally in English without changing the content.

@iliakan iliakan merged commit 19a6d6d into javascript-tutorial:master Dec 5, 2018
@iliakan
Copy link
Member

iliakan commented Dec 5, 2018

Okay, then I assume you're sure of the new wording ;)

@imidom
Copy link
Contributor Author

imidom commented Dec 5, 2018

Sounds good. I'll try to submit a pull request for a chapter a day. Thanks again for creating this tutorial.

@imidom imidom deleted the patch-1 branch December 5, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants