-
Notifications
You must be signed in to change notification settings - Fork 183
Fix possible typos, inaccuracies, omissions in 1.2.8 #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6c87cb9
Fix possible typos, inaccuracies, omissions in 1.2.8
vsemozhetbyt 11171d8
Merge branch 'master' into ch-1-2-8
vsemozhetbyt 39d2943
Update 1-js/02-first-steps/08-operators/4-fix-prompt/solution.md
tarasyyyk 66de3ed
Update 1-js/02-first-steps/08-operators/4-fix-prompt/task.md
tarasyyyk 6ae386c
Update 1-js/02-first-steps/08-operators/article.md
tarasyyyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 13 additions & 13 deletions
26
1-js/02-first-steps/08-operators/4-fix-prompt/solution.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,33 @@ | ||
The reason is that prompt returns user input as a string. | ||
Причина в тому, що вікно запиту повертає ввід користувача як рядок. | ||
|
||
So variables have values `"1"` and `"2"` respectively. | ||
Отже змінні отримують значення `"1"` і `"2"` відповідно. | ||
|
||
```js run | ||
let a = "1"; // prompt("First number?", 1); | ||
let b = "2"; // prompt("Second number?", 2); | ||
let a = "1"; // prompt("Перше число?", 1); | ||
let b = "2"; // prompt("Друге число?", 2); | ||
|
||
alert(a + b); // 12 | ||
``` | ||
|
||
What we should do is to convert strings to numbers before `+`. For example, using `Number()` or | ||
prepending them with `+`. | ||
Нам треба перетворити рядки на числа перед застосуванням оператора `+`. Наприклад, за допомогою `Number()` або вставлення `+` перед ними. | ||
|
||
For example, right before `prompt`: | ||
|
||
Вставити `+` можна безпосередньо перед `prompt`: | ||
|
||
```js run | ||
let a = +prompt("First number?", 1); | ||
let b = +prompt("Second number?", 2); | ||
let a = +prompt("Перше число?", 1); | ||
let b = +prompt("Друге число?", 2); | ||
|
||
alert(a + b); // 3 | ||
``` | ||
|
||
Or in the `alert`: | ||
Або всередині `alert`: | ||
|
||
```js run | ||
let a = prompt("First number?", 1); | ||
let b = prompt("Second number?", 2); | ||
let a = prompt("Перше число?", 1); | ||
let b = prompt("Друге число?", 2); | ||
|
||
alert(+a + +b); // 3 | ||
``` | ||
|
||
Using both unary and binary `+` in the latest code. Looks funny, doesn't it? | ||
В останньому варіанті унарний і бінарний `+` використовуються разом. Виглядає химерно, чи не так? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.