-
Notifications
You must be signed in to change notification settings - Fork 182
Strings #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tarasyyyk
merged 9 commits into
javascript-tutorial:master
from
gingano:translation/strings
Dec 18, 2021
Merged
Strings #230
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f65fcd2
translation added
oleksii-kovalenko-gingano 30e6b82
translation for tasks added
oleksii-kovalenko-gingano 0cda0b1
translation refactoring
oleksii-kovalenko-gingano 6dd2d84
Update 1-js/05-data-types/03-string/3-truncate/_js.view/test.js
tarasyyyk 6a922c0
Update 1-js/05-data-types/03-string/article.md
tarasyyyk a7e515c
Update 1-js/05-data-types/03-string/article.md
tarasyyyk 5714212
Update 1-js/05-data-types/03-string/article.md
tarasyyyk a1ffd76
Apply suggestions from code review
tarasyyyk d15d617
Final corrections
tarasyyyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
describe("ucFirst", function() { | ||
it('Uppercases the first symbol', function() { | ||
it('Перший символ у верхньому регістрі', function() { | ||
assert.strictEqual(ucFirst("john"), "John"); | ||
}); | ||
|
||
it("Doesn't die on an empty string", function() { | ||
it("Не вмирає на порожніх рядках", function() { | ||
gingano marked this conversation as resolved.
Show resolved
Hide resolved
|
||
assert.strictEqual(ucFirst(""), ""); | ||
}); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
describe("checkSpam", function() { | ||
it('finds spam in "buy ViAgRA now"', function() { | ||
it('знайдено спам у "buy ViAgRA now"', function() { | ||
gingano marked this conversation as resolved.
Show resolved
Hide resolved
|
||
assert.isTrue(checkSpam('buy ViAgRA now')); | ||
}); | ||
|
||
it('finds spam in "free xxxxx"', function() { | ||
it('знайдено спам у "free xxxxx"', function() { | ||
assert.isTrue(checkSpam('free xxxxx')); | ||
}); | ||
|
||
it('no spam in "innocent rabbit"', function() { | ||
it('не знайдено спам у "innocent rabbit"', function() { | ||
assert.isFalse(checkSpam('innocent rabbit')); | ||
}); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
1-js/05-data-types/03-string/4-extract-currency/_js.view/test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
describe("extractCurrencyValue", function() { | ||
|
||
it("for the string $120 returns the number 120", function() { | ||
it("для рядка $120 повертає число 120", function() { | ||
assert.strictEqual(extractCurrencyValue('$120'), 120); | ||
}); | ||
|
||
|
||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.