NoSuchMethodError after upgrade

[martinvisser]

After upgrading to version 4.19.2, 4.19.3 or 4.19.4 I get a NoSuchMethodError with regards to Pivotal's cfenv library. This library is a provided library on a Java Buildpack in Cloud Foundry, which means we cannot upgrade it ourselves.

I'm a bit surprised by a patch level upgrade a method now no longer exists, so would be awesome if someone can look into it.

The stack trace:

Caused by: java.lang.NoSuchMethodError: 'java.lang.Object com.cedarsoftware.util.io.JsonReader.jsonToJava(java.lang.String, java.util.Map)'
   at io.pivotal.cfenv.core.JsonIoConverter.jsonToJavaWithListsAndInts(JsonIoConverter.java:39)
   at io.pivotal.cfenv.core.CfEnv.parseVcapServices(CfEnv.java:62)
   at io.pivotal.cfenv.core.CfEnv.<init>(CfEnv.java:44)
   at io.pivotal.cfenv.core.CfEnv.<init>(CfEnv.java:40)
   at io.pivotal.spring.cloud.config.client.ConfigClientOAuth2BootstrapRegistryInitializer.initialize(ConfigClientOAuth2BootstrapRegistryInitializer.java:53)
   at org.springframework.boot.SpringApplication.lambda$createBootstrapContext$1(SpringApplication.java:350)

No issue when downgrading back to 4.19.1.

[jdereg]

You are right in that this upgrade should likely be 4.20 or a 5.0 in that it does change api.

The new API for JsonIo is the static class JsonIo class. In this case, the equivalent API is JsonIo.toObjects(), with the String json as the 1st parameter, a ReadOptions containing the options settings (which used to be passed in a Map, and are now created with new ReadOptionsBuilder().setting1().setting2().build()). The 3rd argument is an optional root class type. You can pass null for this, or the root class type if known a priori.

Please let me know if you have any issues making this change. You can reach me at jdereg@gmail.com.

[martinvisser]

Thanks @jdereg for explaining! The only option for us to downgrade, because we cannot make a change in the buildpack over which we have no influence. I will create an issue there in the hopes it will be picked up.

[jdereg]

I added back the deprecated API which will allow you to upgrade to 4.19.5 and work fine again. Please let me know if you have any issues. That API will stay throughout all 4.x versions, so no reason to worry about it going away. We may keep it in 5.x as well.

[martinvisser]

Yes, awesome! Works like a charm!
Thank you for the quick fix.

[jdereg]

Martin, we found that because the cfenv jar includes 4.19.1 json-io code, and if someone has code running inside the contained environment with a newer version of json-io, both versions are "blended" together and will likely not work. We just released json-4.19.9 that completed "repackages" the code so that none of the classes nor any of the resources are in the same folder as the prior versions.

This removes the NoSuchMethodError or any other unusual errors you may have seen. It appears their build is supposed to "shade" the json-io jar, my understanding being that they intended to move the classes in the jar to their own package space to prevent these types of conflicts, however, the classes are in the same package space in their (cfenv) jar as they are in json-io. We repackage code and resources to eliminate the overlap.

[martinvisser]

That sounds like an interesting way of "shading" indeed, more like copying over the same classes.
I tried upgrading to 4.19.9, but now our deployment fails again though.

Caused by: java.lang.NoClassDefFoundError: com/cedarsoftware/util/io/JsonReader
   at io.pivotal.cfenv.core.JsonIoConverter.jsonToJavaWithListsAndInts(JsonIoConverter.java:39)

Do I need to wait on cfenv being upgraded?

[jdereg]

I have a 4.19.10 coming out today (likely) that will address remaining (hopefully final) issue.

…

On Thu, Mar 14, 2024 at 4:13 AM Martin Visser ***@***.***> wrote: That sounds like an interesting way of "shading" indeed, more like copying over the same classes. I tried upgrading to 4.19.9, but now our deployment fails again though. Caused by: java.lang.NoClassDefFoundError: com/cedarsoftware/util/io/JsonReader at io.pivotal.cfenv.core.JsonIoConverter.jsonToJavaWithListsAndInts(JsonIoConverter.java:39) Do I need to wait on cfenv being upgraded? — Reply to this email directly, view it on GitHub <#274 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABI76TSQGOGNY6NDUKBN23LYYFL25AVCNFSM6AAAAABEP4GFNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJWG44TKNJVGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[cah-renan-ferreira]

Hello!
Having a similar issue. Version 4.19.+ breaks compatibility with who was using 4.18.+

2024-03-20T07:17:20.830-03:00 [APP/PROC/WEB/0] [ERR] Caused by: java.lang.NoClassDefFoundError: com/cedarsoftware/util/io/JsonReader
2024-03-20T07:17:20.830-03:00 [APP/PROC/WEB/0] [ERR] at io.pivotal.cfenv.core.JsonIoConverter.jsonToJavaWithListsAndInts(JsonIoConverter.java:39)
2024-03-20T07:17:20.830-03:00 [APP/PROC/WEB/0] [ERR] at io.pivotal.cfenv.core.CfEnv.parseVcapServices(CfEnv.java:62)
2024-03-20T07:17:20.830-03:00 [APP/PROC/WEB/0] [ERR] at io.pivotal.cfenv.core.CfEnv.(CfEnv.java:44)

[cah-renan-ferreira]

Looks like JsonReader is not inside util/io/ anymore, the class seems to be moved to /util/ and that breaks whoever is using older versions.

[jdereg]

We have added JsonReader and JsonWriter transition version classes to the com.cedarsoftware.util.io package that have the earlier static APIs. Those should bind correctly with your code and get you going again.

The class JsonIo is the main API now. It is packaged at com.cedarsoftware.io. We repackaged the entire libary, and added the transition classes, due to conflicts with a container vendor's usage of json-io. They have an older version of json-io, in the classpath, which, if your application uses json-io, depending on where your jars appear in the classpath, could pick up the vendors or your json-io.jar file. By repackaging our code, it "moves it" out of the way and no longer conflicts with the container vendor's version of classes.

Please let me know if 4.19.10 corrects the NoSuchMethod errors you were seeing.

[martinvisser]

Thanks again for the update @jdereg, but unfortunately there still is an issue during deployment on Cloud Foundry:

Caused by: java.lang.NoClassDefFoundError: com/cedarsoftware/util/io/JsonObject
   at io.pivotal.cfenv.core.JsonIoConverter.jsonToJavaWithListsAndInts(JsonIoConverter.java:39)
   at io.pivotal.cfenv.core.CfEnv.parseVcapServices(CfEnv.java:62)
   at io.pivotal.cfenv.core.CfEnv.<init>(CfEnv.java:44)
   at io.pivotal.cfenv.core.CfEnv.<init>(CfEnv.java:40)
   at io.pivotal.spring.cloud.config.client.ConfigClientOAuth2BootstrapRegistryInitializer.initialize(ConfigClientOAuth2BootstrapRegistryInitializer.java:53)

[cah-renan-ferreira]

We have added JsonReader and JsonWriter transition version classes to the com.cedarsoftware.util.io package that have the earlier static APIs. Those should bind correctly with your code and get you going again.

The class JsonIo is the main API now. It is packaged at com.cedarsoftware.io. We repackaged the entire libary, and added the transition classes, due to conflicts with a container vendor's usage of json-io. They have an older version of json-io, in the classpath, which, if your application uses json-io, depending on where your jars appear in the classpath, could pick up the vendors or your json-io.jar file. By repackaging our code, it "moves it" out of the way and no longer conflicts with the container vendor's version of classes.

Please let me know if 4.19.10 corrects the NoSuchMethod errors you were seeing.

Thanks for the answer.

I think what you guys are doing is a breaking change.
Look at my situation here, this dependency is being introduced indirectly by
'io.pivotal.spring.cloud:spring-cloud-services-starter-service-registry'

The version this lib is using (4.x) has some CVE vulnerabilities and we wanted to force an upgrade to the latest 4.x and that broke the code, since you guys moved classes from packages.

If you guys really want to move packages, this should probably be a 5.x version.

Thanks all!