-
Notifications
You must be signed in to change notification settings - Fork 60
feat: allow csi controllers to use client-go's leader election label functionality #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: allow csi controllers to use client-go's leader election label functionality #200
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DerekFrank The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @DerekFrank! |
Hi @DerekFrank. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
k8s.io/api v0.34.0-alpha.1 | ||
k8s.io/client-go v0.34.0-alpha.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably wait for GA of 1.34. Otherwise dependabot gets crazy and too eager to update to 1.35 alpha, once it's released.
@@ -122,6 +124,10 @@ func (l *leaderElection) WithReleaseOnCancel(releaseOnCancel bool) { | |||
l.releaseOnCancel = releaseOnCancel | |||
} | |||
|
|||
func (l *leaderElection) WithLabels(labels map[string]string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can we add a GoDoc comment to match rest of exported functions?
Perhaps something like:
// WithLabels adds labels on Lease resource when a new leader is elected
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR allows consumers of csi-lib-utils to leverage client-go's lease label functionality: kubernetes/kubernetes#131632
Which issue(s) this PR fixes:
Fixes #194
Special notes for your reviewer:
Does this PR introduce a user-facing change?: