-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[feat gw-api]implement finalizer #4217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shuqz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @shuqz. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -284,6 +297,93 @@ func (r *gatewayReconciler) reconcileUpdate(ctx context.Context, gw *gwv1.Gatewa | |||
return nil | |||
} | |||
|
|||
// add finalizer to load balancer configuration when it is in use by gateway or gatewayClass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move these adding and removing finalizers methods to FinalizerManager to consolidate them under same manager?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During offline conversation with Shraddha, she found an edge case when GWA and GWB both refers to GWClass-A. and GWClass A has lbConfig. in this case, when GWA and GWB both got deleted, there is no reconcile to trigger finalizer removal on the remaining gatewayClass based on current logic, will address it
h.enqueueImpactedRoutes(ctx, svc) | ||
} | ||
|
||
func (h *enqueueRequestsForServiceEvent) removeTargetGroupConfigurationFinalizer(ctx context.Context, svc *corev1.Service) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same lets move this to FinalizerManager
refactor code and add unit tests fix logic bug
Description
Checklist
README.md
, or thedocs
directory)========== test targetgroupconfiguration =======
targetgroupconfiguration will be removed when service is deleted
Test process:
Result
Load balancer Configuration result
BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯