tg / lb conf finalizers #4230
Merged
tg / lb conf finalizers #4230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XXL
zac-nixon
force-pushed
the
main
branch
3 times, most recently
from
a7ddcae to
0e7363a
Compare
| @@ -60,13 +58,16 @@ func (h *enqueueRequestsForGatewayClassEvent) Generic(ctx context.Context, e eve | |||
| } | |||
|
|
|||
| func (h *enqueueRequestsForGatewayClassEvent) enqueueImpactedGateways(ctx context.Context, gwClass *gatewayv1.GatewayClass, queue workqueue.TypedRateLimitingInterface[reconcile.Request]) { | |||
| gwList := gatewayutils.GetGatewaysManagedByGatewayClass(ctx, h.k8sClient, gwClass, h.gwController) | |||
| gwList, err := gatewayutils.GetGatewaysManagedByLBController(ctx, h.k8sClient, h.gwController) | |||
There was a problem hiding this comment.
We should only enqueue the Gateways which are managed by GatewayClass rather than controller for gwclass events. Use GetGatewaysManagedByGatewayClass
| @@ -165,7 +167,11 @@ type gatewayReconciler struct { | |||
| func (r *gatewayReconciler) Reconcile(ctx context.Context, req reconcile.Request) (ctrl.Result, error) { | |||
| r.reconcileTracker(req.NamespacedName) | |||
| err := r.reconcileHelper(ctx, req) | |||
| return runtime.HandleReconcileError(err, r.logger) | |||
| res, reconcileErr := runtime.HandleReconcileError(err, r.logger) | |||
There was a problem hiding this comment.
Why cant we simply return runtime.HandleReconcileError(err, r.logger)?
There was a problem hiding this comment.
initially had logging here, will change back
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds finalizers to TargetGroupConfiguration, LoadbalancerConfiguration, and GatewayClass (only if the controller manages it).
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯