initial go modules draft #908

liggitt · 2019-03-20T17:28:31Z

Initial go modules draft KEP.

/sig architecture testing release api-machinery

/cc @lavalamp @sttts

keps/sig-architecture/2019-03-19-go-modules.md

cblecker

initial kep lgtm. thumbs up to merge and iterate from me.

keps/sig-architecture/2019-03-19-go-modules.md

mattfarina

@liggitt Nicely written and the timing works well. Thanks for putting this together.

keps/sig-architecture/2019-03-19-go-modules.md

mattfarina · 2019-03-20T18:30:21Z

/hold
/lgtm

Adding hold until an approver on the KEP pokes at it.

dims · 2019-03-21T04:48:38Z

LGTM, +1 to merge and iterate!

idealhack · 2019-03-21T12:29:49Z

/cc

feiskyer

this is cool. lgtm

mattfarina · 2019-03-21T17:57:38Z

@smarterclayton @thockin can either of you approve this so we can merge?

keps/sig-architecture/2019-03-19-go-modules.md

lavalamp · 2019-03-21T19:48:33Z

keps/sig-architecture/2019-03-19-go-modules.md

+          * uses latest commits of transitive non-module-based dependencies (likely to break, as today)
+      * module-based consumers
+        * reference published modules versions as a consistent `vX.y.z` version (e.g. `v15.0.0`)
+        * import `k8s.io/apimachinery/v15/...` (have to rewrite kubernetes component imports on every major version bump)


Conversely, if we actually did the right thing (as defined by go) and kept the old versions functioning correctly (e.g. v14.x.y itself imports v15 and adapts), then this would only be necessary when people actually wanted the new interface.

...I'm not claiming the demand go makes is reasonable, but if old packages stop working or stop working with new packages, we are not doing it the way they intended.

I'm not necessarily opposed to adopting semantic import versioning, but I see that as a discrete step, and one that should wait at least until we don't have to worry about GOPATH consumers as well

lavalamp · 2019-03-21T19:49:43Z

keps/sig-architecture/2019-03-19-go-modules.md

+  - "@mattfarina"
+approvers:
+  - "@smarterclayton"
+  - "@thockin"


I'm also willing to be on either of these lines

smarterclayton · 2019-03-21T22:56:33Z

/approve

For initial status. Agreed with Jordan’s assessment on semantic versioning being a discrete step and orthogonal to short term inprovements to tooling.

liggitt · 2019-03-22T03:12:22Z

unholding, will fold in updates for some comments in the next PR

/hold cancel

dims · 2019-03-22T03:15:25Z

/lgtm

(@mattfarina and @cblecker indicated their LGTM earlier plus mine as well)

k8s-ci-robot · 2019-03-22T03:15:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, mattfarina, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~keps/OWNERS~~ [mattfarina]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

thockin

As part of this, perhaps we can also simplify some of the hack/* tools (e.g. get rid of run-in-gopath.sh) and maybe simplify the _output/... mess

liggitt · 2019-03-25T15:48:22Z

As part of this, perhaps we can also simplify some of the hack/* tools (e.g. get rid of run-in-gopath.sh) and maybe simplify the _output/... mess

I'd like to see those things get cleaned up, definitely, but we're sitting in between GOPATH and go modules at the moment. The output of this proposal produces a k8s.io/kubernetes repo that can work with go modules or with GOPATH. Once we're solidly in go modules territory (go 1.13+, possibly?) it will be more reasonable to require using go modules to build.

liggitt · 2019-03-25T15:48:38Z

next PR updating this KEP is in #916

k8s-ci-robot requested review from lavalamp and sttts March 20, 2019 17:28

liggitt force-pushed the go-module-kep branch from 0d6cf6b to b8cdfa4 Compare March 20, 2019 17:29

initial go modules draft

9730b06

liggitt force-pushed the go-module-kep branch from b8cdfa4 to 9730b06 Compare March 20, 2019 17:30

This was referenced Mar 20, 2019

go modules adoption checklist kubernetes/kubernetes#68577

Closed

add go module support, manage vendor directory using go mod vendor kubernetes/kubernetes#74877

Merged

sttts reviewed Mar 20, 2019

View reviewed changes

keps/sig-architecture/2019-03-19-go-modules.md Outdated Show resolved Hide resolved

cblecker reviewed Mar 20, 2019

View reviewed changes

keps/sig-architecture/2019-03-19-go-modules.md Show resolved Hide resolved

cblecker reviewed Mar 20, 2019

View reviewed changes

keps/sig-architecture/2019-03-19-go-modules.md Outdated Show resolved Hide resolved

mattfarina approved these changes Mar 20, 2019

View reviewed changes

k8s-ci-robot assigned mattfarina Mar 20, 2019

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 20, 2019

liggitt added 5 commits March 20, 2019 14:40

add reviewers

a04675a

clarify forward paths for versioning strategies

046a33f

Update version strategy details

6fae84c

propose version strategy, move others to alternatives considered

50bc521

Incorporate comments

a46be46

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2019

liggitt requested a review from thockin March 21, 2019 04:22

liggitt requested a review from smarterclayton March 21, 2019 04:22

fix formatting and spelling

70123a7

k8s-ci-robot requested a review from idealhack March 21, 2019 12:29

feiskyer reviewed Mar 21, 2019

View reviewed changes

lavalamp reviewed Mar 21, 2019

View reviewed changes

keps/sig-architecture/2019-03-19-go-modules.md Show resolved Hide resolved

lavalamp reviewed Mar 21, 2019

View reviewed changes

keps/sig-architecture/2019-03-19-go-modules.md Show resolved Hide resolved

lavalamp reviewed Mar 21, 2019

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2019

k8s-ci-robot assigned dims Mar 22, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2019

k8s-ci-robot merged commit 3dd7391 into kubernetes:master Mar 22, 2019

thockin reviewed Mar 22, 2019

View reviewed changes

liggitt mentioned this pull request Feb 18, 2020

Add go module support to k8s.io/kubernetes #917

Closed

initial go modules draft #908

initial go modules draft #908

Uh oh!

Conversation

liggitt commented Mar 20, 2019

Uh oh!

Uh oh!

Uh oh!

cblecker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattfarina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattfarina commented Mar 20, 2019

Uh oh!

dims commented Mar 21, 2019

Uh oh!

idealhack commented Mar 21, 2019

Uh oh!

feiskyer left a comment

Choose a reason for hiding this comment

Uh oh!

mattfarina commented Mar 21, 2019

Uh oh!

Uh oh!

Uh oh!

lavalamp Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

liggitt Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

lavalamp Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

lavalamp Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

smarterclayton commented Mar 21, 2019

Uh oh!

liggitt commented Mar 22, 2019

Uh oh!

dims commented Mar 22, 2019

Uh oh!

k8s-ci-robot commented Mar 22, 2019

Uh oh!

thockin left a comment

Choose a reason for hiding this comment

Uh oh!

liggitt commented Mar 25, 2019

Uh oh!

liggitt commented Mar 25, 2019

Uh oh!

Uh oh!