libgit 0.28 compatible release

[0-wiz-0]

Please release a version of pygit2 that's compatible with the current latest release of libgit, 0.28.1.
Thanks.

[mwilck]

I'm interested in this one too. The recent update of libgit2 on openSUSE Factory has broken pygit2. I'd appreciate some information when a 0.28.0-compatible release might be available, or what changes are anticipated to make pygit2 work with libgit2 0.28.0.

[jayvdb]

The repo here is now using 0.28 since 8dabd78, however 11 tests are failing as seen at https://travis-ci.org/libgit2/pygit2/jobs/501118496

These failures correlate with breaking changes in the 0.28 relnotes at https://github.com/libgit2/libgit2/blob/master/docs/changelog.md

[jdavid]

There's 1 failure left now:

E       GitError: failed to insert entry: invalid object specified - .gitignore

If someone wants to give it a try 😉

[webknjaz]

I don't have time to dig into this myself but just to confirm: are you going to create a release once the CI is green?

[jdavid]

yes, there's nothing else blocking the release I think

[jdavid]

This failure is actually a regression in libgit2, see libgit2/libgit2#5015

@webknjaz @imbuedhope The tests in AppVeyor are failing as well for a different reason, since PR #884 was merged, see https://ci.appveyor.com/project/jdavid/pygit2/branch/master/job/mwf4pj02fe0yubwk#L7514

test\utils.py:42: in <module>
    import pygit2
pygit2\__init__.py:269: in <module>
    settings = Settings()
pygit2\settings.py:65: in __init__
    self._default_tls_verify_paths.capath,
pygit2\settings.py:151: in set_ssl_cert_locations
    option(GIT_OPT_SET_SSL_CERT_LOCATIONS, ssl_cert_file, ssl_cert_dir)
E   GitError: TLS backend doesn't support certificate locations

[webknjaz]

@jdavid I think, this should probably be turned off under Windows. Another option would be building Windows wheels against OpenSSL.

[jdavid]

@fourplusone

[webknjaz]

Another solution would be wrapping things with try/except and ignoring just this specific error.

[webknjaz]

I think, try/except in the initializer is all we need.

[webknjaz]

PR incoming

[webknjaz]

@jdavid this should fix it in a generic OS-independent way: #886. I don't have a windows machine to test it, though. So we'll have to wait for what AppVeyor CI has to say...