Upgrade to LDK 0.2 #462
Draft
Upgrade to LDK 0.2 #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2025-02-upgrade-to-ldk-0.2
branch
3 times, most recently
from
822bd94 to
c7b7464
Compare
tnull
force-pushed
the
2025-02-upgrade-to-ldk-0.2
branch
3 times, most recently
from
5c97913 to
528d7cc
Compare
tnull
force-pushed
the
2025-02-upgrade-to-ldk-0.2
branch
2 times, most recently
from
572ff55 to
a12ceaf
Compare
tnull
force-pushed
the
2025-02-upgrade-to-ldk-0.2
branch
from
a12ceaf to
627a453
Compare
tnull
force-pushed
the
2025-02-upgrade-to-ldk-0.2
branch
from
627a453 to
b341b76
Compare
tnull
force-pushed
the
2025-02-upgrade-to-ldk-0.2
branch
from
9f3285f to
c7483f8
Compare
tnull
force-pushed
the
2025-02-upgrade-to-ldk-0.2
branch
from
c7483f8 to
3232202
Compare
tnull
force-pushed
the
2025-02-upgrade-to-ldk-0.2
branch
from
3232202 to
bbfea66
Compare
As part of the version v0.3 release we switched to the upstreamed `OutputSweeper` which slightly changed our serialization format, having us run a migration step on startup for backwards compatibility ever since. Here we drop the migration code running on startup, for simplicity's sake, but also because it's going to be async going forward and we currently don't have a runtime available on startup (which might change soon, but still). As the v0.3 release now well over a year ago, it's very unlikely that there are any v0.2 (or even v0.3) users left. If there are any affected users left, they'll first have to upgrade to any version pre-v0.7, startup, and then upgrade to v0.7 or later.
.. as having them in two places doesn't make sense
.. we now apply the LSPS2 client-side overrides on a per-counterparty basis, not as soon as we act as an LSP client
.. we implement the `async` version of `ChangeDestinationSource`, and, to make all involved objects `Send`, we drop the `Deref` generics for concrete `Arc`s everywhere.
tnull
force-pushed
the
2025-02-upgrade-to-ldk-0.2
branch
from
bbfea66 to
0cd3b4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.