Skip to content

Remove deprecated lightning::util::string re-exports #3914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

TheBlueMatt
Copy link
Collaborator

These were deprecated in 0.1 in favor of the lightning::types re-export of the lightning-types crate.

Fixes #3251.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jul 7, 2025

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

These were deprecated in 0.1 in favor of the `lightning::types`
re-export of the `lightning-types` crate.

Fixes lightningdevkit#3251.
@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@wpaulino wpaulino merged commit d67bd0f into lightningdevkit:main Jul 7, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move lightning::ln::types::* to lightning-types
3 participants