Skip to content

Fix silent rebase conflict in reorg_tests.rs #3929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Jul 15, 2025

Commit d7726ef introduced a test using a ClosureReason::HolderForceClosed variant absent of the recently-introduced message field, resulting in failing tests on main.

Here, we fix this silent conflict.

Commit d7726ef introduced a test using
a `ClosureReason::HolderForceClosed` variant absent of the
recently-introduced `message` field, resulting in failing tests on `main`.

Here, we fix this silent conflict.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jul 15, 2025

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@tnull tnull merged commit ee4211e into lightningdevkit:main Jul 15, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants