[NFC][CIR] Remove unnecessary ComplexRangeKind #1779
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlauko
approved these changes
Aug 7, 2025
| @@ -802,7 +802,8 @@ getComplexRangeAttr(LangOptions::ComplexRangeKind range) { | |||
| case LangOptions::CX_Basic: | |||
| return cir::ComplexRangeKind::Basic; | |||
| case LangOptions::CX_None: | |||
| return cir::ComplexRangeKind::None; | |||
| // The default value for ComplexRangeKind is Full is no option is selected | |||
There was a problem hiding this comment.
Suggested change
| // The default value for ComplexRangeKind is Full is no option is selected | |
| // The default value for ComplexRangeKind is Full if no option is selected |
There was a problem hiding this comment.
Thank you for catching it. I will update it in the upstream, too
AmrDeveloper
added a commit
to llvm/llvm-project
that referenced
this pull request
Aug 7, 2025
Fix typo in ComplexRangeKind comment Catched in llvm/clangir#1779
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 7, 2025
Fix typo in ComplexRangeKind comment Catched in llvm/clangir#1779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting remove unnecessary ComplexRangeKind