-
Notifications
You must be signed in to change notification settings - Fork 14.6k
Closed
Labels
cmakeBuild system in general and CMake in particularBuild system in general and CMake in particularopenmprelease:backport
Milestone
Description
While building openmp 18.1.0-rc1 on windows, I get:
CMake Error at cmake/HandleOpenMPOptions.cmake:47 (append):
Unknown CMake command "append".
This is due to https://github.com/llvm/llvm-project/blame/release/18.x/openmp/cmake/HandleOpenMPOptions.cmake using append
since 15fdc76, but not defining it -- in contrast to append_if
which explicitly duplicates the definition from HandleLLVMOptions.cmake
:
llvm-project/openmp/cmake/HandleOpenMPOptions.cmake
Lines 1 to 10 in 400a02b
if (NOT COMMAND append_if) | |
# From HandleLLVMOptions.cmake | |
function(append_if condition value) | |
if (${condition}) | |
foreach(variable ${ARGN}) | |
set(${variable} "${${variable}} ${value}" PARENT_SCOPE) | |
endforeach(variable) | |
endif() | |
endfunction() | |
endif() |
I don't know why this file does not (or cannot) do include(HandleLLVMOptions)
, but if that's not an option, then it needs to similarly vendor the definition of append
.
CC @aganea
Metadata
Metadata
Assignees
Labels
cmakeBuild system in general and CMake in particularBuild system in general and CMake in particularopenmprelease:backport
Type
Projects
Status
Done