Skip to content

[mlir][core] NFC update builder create API usage #147311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[mlir][core] NFC update builder create API usage #147311

wants to merge 5 commits into from

Conversation

makslevental
Copy link
Contributor

@makslevental makslevental commented Jul 7, 2025 •
edited
Loading

See #147168

TODO: update ops that use "custom" build methods (like arith::ConstantIndexOp)

@makslevental makslevental changed the title Makslevental/update create api [mlir][core] NFC update builder create API usage Jul 7, 2025
@makslevental makslevental mentioned this pull request Jul 7, 2025
Merged
@makslevental makslevental force-pushed the makslevental/update-create-api branch 8 times, most recently from 99616f1 to 0aeb797 Compare July 11, 2025 22:33
@makslevental makslevental force-pushed the makslevental/update-create-api branch from 837374a to 5881ed8 Compare July 14, 2025 16:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@makslevental makslevental force-pushed the makslevental/update-create-api branch from 5881ed8 to b69c5b8 Compare July 14, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftynse ftynse Awaiting requested review from ftynse ftynse will be requested when the pull request is marked ready for review ftynse is a code owner

@stellaraccident stellaraccident Awaiting requested review from stellaraccident stellaraccident will be requested when the pull request is marked ready for review stellaraccident is a code owner

@Mogball Mogball Awaiting requested review from Mogball Mogball will be requested when the pull request is marked ready for review Mogball is a code owner

@grypp grypp Awaiting requested review from grypp grypp will be requested when the pull request is marked ready for review grypp is a code owner

@aartbik aartbik Awaiting requested review from aartbik aartbik will be requested when the pull request is marked ready for review aartbik is a code owner

@PeimingLiu PeimingLiu Awaiting requested review from PeimingLiu PeimingLiu will be requested when the pull request is marked ready for review PeimingLiu is a code owner

@yinying-lisa-li yinying-lisa-li Awaiting requested review from yinying-lisa-li yinying-lisa-li will be requested when the pull request is marked ready for review yinying-lisa-li is a code owner

@matthias-springer matthias-springer Awaiting requested review from matthias-springer matthias-springer will be requested when the pull request is marked ready for review matthias-springer is a code owner

@antiagainst antiagainst Awaiting requested review from antiagainst antiagainst will be requested when the pull request is marked ready for review antiagainst is a code owner

@kuhar kuhar Awaiting requested review from kuhar kuhar will be requested when the pull request is marked ready for review kuhar is a code owner

@nicolasvasilache nicolasvasilache Awaiting requested review from nicolasvasilache nicolasvasilache will be requested when the pull request is marked ready for review nicolasvasilache is a code owner

@hanhanW hanhanW Awaiting requested review from hanhanW hanhanW will be requested when the pull request is marked ready for review hanhanW is a code owner

@dcaballe dcaballe Awaiting requested review from dcaballe dcaballe will be requested when the pull request is marked ready for review dcaballe is a code owner

@banach-space banach-space Awaiting requested review from banach-space banach-space will be requested when the pull request is marked ready for review banach-space is a code owner

@Groverkss Groverkss Awaiting requested review from Groverkss Groverkss will be requested when the pull request is marked ready for review Groverkss is a code owner

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar will be requested when the pull request is marked ready for review MaheshRavishankar is a code owner

@rengolin rengolin Awaiting requested review from rengolin rengolin will be requested when the pull request is marked ready for review rengolin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@makslevental