Skip to content

[PATCH 2/7] [clang] improve NestedNameSpecifier: misc small clang changes #148012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: users/mizvekov/name-qualification-refactor
Choose a base branch
from
Open

[PATCH 2/7] [clang] improve NestedNameSpecifier: misc small clang changes #148012

wants to merge 1 commit into from
+1,895 −1,938

Conversation

mizvekov
Copy link
Contributor

Other changes

Second patch in the series starting at #147835

@mizvekov mizvekov self-assigned this Jul 10, 2025
@llvmbot llvmbot added clang Clang issues not falling into any other category backend:ARM backend:AArch64 backend:AMDGPU backend:Hexagon backend:MIPS backend:RISC-V backend:PowerPC backend:Sparc backend:SystemZ backend:WebAssembly backend:X86 clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:modules C++20 modules and Clang Header Modules clang:codegen IR generation bugs: mangling, exceptions, etc. clang:as-a-library libclang and C++ API clang:static analyzer debuginfo backend:CSKY HLSL HLSL Language Support coroutines C++20 coroutines labels Jul 10, 2025
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor branch from 374aefc to 8da8c53 Compare July 10, 2025 20:14
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch 2 times, most recently from ddaea06 to b16b022 Compare July 11, 2025 00:05
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor branch 2 times, most recently from 7b74782 to cfe89c1 Compare July 12, 2025 17:40
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch 2 times, most recently from 1d0abee to 1e4b214 Compare July 14, 2025 21:46
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor branch 2 times, most recently from 42d0f68 to 4896f42 Compare July 20, 2025 05:48
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch from 1e4b214 to 7ad6252 Compare July 20, 2025 05:48
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor branch from 4896f42 to 73ffe31 Compare July 20, 2025 23:41
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch from 7ad6252 to b37d904 Compare July 20, 2025 23:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 20, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@mizvekov mizvekov changed the title [PATCH 2/4] [clang] Improve nested name specifier AST representation [PATCH 2/6] [clang] Improve nested name specifier AST representation Jul 20, 2025
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor branch from 73ffe31 to d8acbe8 Compare July 21, 2025 00:07
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch 2 times, most recently from 533e517 to 365a333 Compare July 21, 2025 03:27
@mizvekov mizvekov requested a review from DeinAlptraum as a code owner July 21, 2025 03:27
DeinAlptraum
DeinAlptraum reviewed Jul 21, 2025
View reviewed changes
Copy link
Contributor

@DeinAlptraum DeinAlptraum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: Python bindings changes.
The tests currently fail because the libclang.so cannot even be built. Is this expected, as in, can it only be built after the last patch again? (I see that the tests passed on patch 6/6).

This should also probably get an entry in the bindings' breaking changes section of the release notes.

erichkeane
erichkeane approved these changes Jul 21, 2025
View reviewed changes
Copy link
Collaborator

@erichkeane erichkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did as in depth of a review of this as I could, nothing sticks out to me.

@mizvekov
Copy link
Contributor Author

Re: Python bindings changes.

The tests currently fail because the libclang.so cannot even be built. Is this expected, as in, can it only be built after the last patch again? (I see that the tests passed on patch 6/6).

Yes, but all of the patches will be squashed before merging.

This should also probably get an entry in the bindings' breaking changes section of the release notes.

Will do, thanks.

@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch from 365a333 to 32e2a03 Compare July 21, 2025 23:55
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor branch from d8acbe8 to 58b801e Compare July 21, 2025 23:55
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch from 32e2a03 to d265b06 Compare July 22, 2025 00:01
@mizvekov mizvekov changed the title [PATCH 2/6] [clang] Improve nested name specifier AST representation [PATCH 2/7] [clang] Improve nested name specifier AST representation Jul 22, 2025
@mizvekov mizvekov changed the title [PATCH 2/7] [clang] Improve nested name specifier AST representation [PATCH 2/7] [clang] improve NestedNameSpecifier: misc changes Jul 22, 2025
@mizvekov mizvekov changed the title [PATCH 2/7] [clang] improve NestedNameSpecifier: misc changes [PATCH 2/7] [clang] improve NestedNameSpecifier: misc small clang changes Jul 22, 2025
@mizvekov
[PATCH 2/7] [clang] improve NestedNameSpecifier: misc small clang cha…
b6b18fb 
…nges

Other changes

Second patch in the series starting at #147835
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor branch from 58b801e to dcef00f Compare July 22, 2025 19:53
@mizvekov mizvekov force-pushed the users/mizvekov/name-qualification-refactor-2 branch from d265b06 to b6b18fb Compare July 22, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeinAlptraum DeinAlptraum DeinAlptraum left review comments

@efriedma-quic efriedma-quic efriedma-quic left review comments

@erichkeane erichkeane erichkeane approved these changes

@cor3ntin cor3ntin Awaiting requested review from cor3ntin

@shafik shafik Awaiting requested review from shafik

@Sirraide Sirraide Awaiting requested review from Sirraide

@zyn0217 zyn0217 Awaiting requested review from zyn0217

@daniel-grumberg daniel-grumberg Awaiting requested review from daniel-grumberg daniel-grumberg is a code owner

@QuietMisdreavus QuietMisdreavus Awaiting requested review from QuietMisdreavus QuietMisdreavus is a code owner

@cyndyishida cyndyishida Awaiting requested review from cyndyishida cyndyishida is a code owner

Assignees

@mizvekov mizvekov

Labels
backend:AArch64 backend:AMDGPU backend:ARC backend:ARM backend:CSKY backend:Hexagon backend:Lanai backend:loongarch backend:MIPS backend:PowerPC backend:RISC-V backend:Sparc backend:SystemZ backend:WebAssembly backend:X86 clang:analysis clang:as-a-library libclang and C++ API clang:codegen IR generation bugs: mangling, exceptions, etc. clang:dataflow Clang Dataflow Analysis framework - https://clang.llvm.org/docs/DataFlowAnalysisIntro.html clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:modules C++20 modules and Clang Header Modules clang:openmp OpenMP related changes to Clang clang:static analyzer clang Clang issues not falling into any other category coroutines C++20 coroutines debuginfo HLSL HLSL Language Support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mizvekov @llvmbot @erichkeane @DeinAlptraum @efriedma-quic