[AssignmentTracking][NFC] Cache interesting debug records and instructions #149514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCHyams
commented
Jul 21, 2025
| // Process the instructions in "frames". A "frame" includes a single | ||
| // non-debug instruction followed any debug instructions before the | ||
| // next non-debug instruction. A pointer-int int value of 1 on an | ||
| // instruction means non-debug instructions follow (end of frame). |
There was a problem hiding this comment.
err, note to self, this comment has the bit value the wrong way around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than visit all instructions each iteration of the analysis, we can cache the interesting ones ahead of time while performing other setup related tasks.
Marginal performance improvement. Note in this compile-tim-tracker comparison I've enabled assignment tracking support with lto, which isn't the same as on main:
http://llvm-compile-time-tracker.com/compare.php?from=80d92fc648d0160e0bbd191ba67b0f05218d4b69&to=1a38acc6e758919bbce5a451b7fe39c89a134c01&stat=instructions%3Au