[libclc] Revert the recent breaking changes from CMake from the 21.x release branch #149711
+68
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lvm#148815)" This reverts commit 8a7a648. It broke standalone builds since the necessary variables are now limited in scope to `libclc/utils` while they are used in the top-level CMakeLists.
This reverts commit 9b5959d.
This reverts commit 222e795.
This reverts commit 81e6552. This change caused libclc to start installing broken symlinks that contain absolute paths to the build directory rather than relative paths within the install directory.
This reverts commit 85d09de. This change caused broken symlinks in the build directory, and the subsequent commits fixing that introduced other issues.
mgorny
requested review from
MaskRay,
sylvestre,
DavidSpickett,
frasercrmck and
thesamesam
github-project-automation
bot
moved this from Needs Triage
to Needs Merge
in LLVM Release Status
thesamesam
approved these changes
Jul 21, 2025
frasercrmck
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the recent batch of changes to the CMake build of libclc that introduced significant breakage, notably:
These changes are nontrivial and were made shortly prior to the branching point, so it's better to defer them to 22.x and fix properly than attempt to apply more ad hoc fixes.
Fixes #149659
Fixes #149437