Skip to content

[LifetimeSafety] Do not create two loans for the same expression #153669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[LifetimeSafety] Do not create two loans for the same expression #153669

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d28dc
[LifetimeSafety] Track view types/gsl::Pointer.
usx95 Aug 14, 2025
e61817a
[LifetimeSafety] Do not create two loans for the same expression
usx95 Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions clang/lib/Analysis/LifetimeSafety.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,12 +396,18 @@ class FactGenerator : public ConstStmtVisitor<FactGenerator> {
// initializations and destructions are processed in the correct sequence.
for (const CFGBlock *Block : *AC.getAnalysis<PostOrderCFGView>()) {
CurrentBlockFacts.clear();
VisitedStmts.clear();
for (unsigned I = 0; I < Block->size(); ++I) {
const CFGElement &Element = Block->Elements[I];
if (std::optional<CFGStmt> CS = Element.getAs<CFGStmt>())
if (std::optional<CFGStmt> CS = Element.getAs<CFGStmt>()) {
DEBUG_WITH_TYPE("PrintCFG",
llvm::dbgs()
<< "======CFGStmt and ASTStmt========\n");
DEBUG_WITH_TYPE("PrintCFG", CS->dump());
DEBUG_WITH_TYPE("PrintCFG", CS->getStmt()->dumpColor());
Visit(CS->getStmt());
else if (std::optional<CFGAutomaticObjDtor> DtorOpt =
Element.getAs<CFGAutomaticObjDtor>())
} else if (std::optional<CFGAutomaticObjDtor> DtorOpt =
Element.getAs<CFGAutomaticObjDtor>())
handleDestructor(*DtorOpt);
}
FactMgr.addBlockFacts(Block, CurrentBlockFacts);
Expand Down
Loading