Skip to content

[SYCL]Use subgroup size of 16 as default in InlineASM tests #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1,237 commits into from

Conversation

stdale-intel
Copy link

Since sgsize = 8 is not supported on all platforms, this PR use sgsize = 16 instead as it is common across gpu platforms for tests not specifically testing a given sgsize (ie.. asm_8_, asm_16_,malloc_shared_32)

steffenlarsen and others added 30 commits August 25, 2022 20:42
SYCL2020 changes the default constructor of both platform and device
from using host to using the objects associated with the default device
selector. This commit adjusts for this change in behaviour.
Additionally, this commit also adds tests for the default constructor
behaviour for both platform and device.

Signed-off-by: Larsen, Steffen <[email protected]>
SYCL 2020 defines a common property interface for accessor and host_accessor.
SYCL patch: intel/llvm#6614
* [ESIMD] Add tests for atomic operations.

Signed-off-by: Konstantin S Bobrovsky <[email protected]>
* [ESIMD] Add a LIT test verifying DPAS with 2 tfloat32 arguments

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
* Adding 'esimd_emulator' feature for LSC tests
* XFAIL marking for unsupported lsc-atomic tests
* Enabling LSC-Atomic tests
- lsc_usm_atomic_cachehint.cpp is excluded as kernel_bundle() is not
supported under ESIMD_EMULATOR
This PR updates tests that use `target::local` to local_accessor. In all cases the change should not functionally change the test. The goal is to move from the deprecated `target::local` accessor to `local_accessor`.

Depends on: intel/llvm#6341
…e. (#1227)

Also decrease number of threads to reduce risk of halting kernel by the
driver.

Signed-off-by: Konstantin S Bobrovsky <[email protected]>
* [ESIMD] Add bfloat16 test cases - binary ops, unary plus, memory access, taking a view.
According to SYCL2020 sycl::program is deprecated and should be removed.
Related compiler change: intel/llvm#6666
This commit removes the host run and any assumptions and operations
related to the host device from the tests in SYCL/Plugin.

Signed-off-by: Larsen, Steffen <[email protected]>
Co-authored-by: Sachkov, Alexey <[email protected]>
)

This commit removes the host run and any assumptions and operations
related to the host device from the tests in SYCL/Reduction.

Signed-off-by: Larsen, Steffen <[email protected]>
Co-authored-by: Sachkov, Alexey <[email protected]>
This commit removes the host run and any assumptions and operations
related to the host device from the tests in SYCL/Sampler.

Signed-off-by: Larsen, Steffen <[email protected]>
Co-authored-by: Sachkov, Alexey <[email protected]>
#1208)

This commit removes the host run and any assumptions and operations
related to the host device from the tests in SYCL/FilterSelector.

Signed-off-by: Larsen, Steffen <[email protected]>
Co-authored-by: Sachkov, Alexey <[email protected]>
…#1219)

This commit removes the host run and any assumptions and operations
related to the host device from the tests in SYCL/SpecConstants.

Signed-off-by: Larsen, Steffen <[email protected]>
Co-authored-by: Sachkov, Alexey <[email protected]>
…1202)

This commit removes the host run and any assumptions and operations
related to the host device from the tests in SYCL/DeviceGlobal.

Signed-off-by: Larsen, Steffen <[email protected]>
Co-authored-by: Sachkov, Alexey <[email protected]>
This commit removes the host run and any assumptions and operations
related to the host device from the tests in SYCL/SubGroup.

Signed-off-by: Larsen, Steffen <[email protected]>
Co-authored-by: Sachkov, Alexey <[email protected]>
#1210)

This commit removes the host run and any assumptions and operations
related to the host device from the tests in SYCL/GroupAlgorithm.

Signed-off-by: Larsen, Steffen <[email protected]>
Co-authored-by: Sachkov, Alexey <[email protected]>
#1214)

This commit removes the host run and any assumptions and operations
related to the host device from the tests in SYCL/OnlineCompiler.

Signed-off-by: Larsen, Steffen <[email protected]>
Co-authored-by: Sachkov, Alexey <[email protected]>
…1212)

This commit removes the host run and any assumptions and operations
related to the host device from the tests in SYCL/InorderQueue.

Co-authored-by: Sachkov, Alexey <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
This commit removes the host run and any assumptions and operations
related to the host device from the tests in SYCL/Functor.

Signed-off-by: Larsen, Steffen <[email protected]>
Co-authored-by: Sachkov, Alexey <[email protected]>
* [SYCL] Add bfloat16 'hello world' host test.

Signed-off-by: Konstantin S Bobrovsky <[email protected]>
This commit removes the host run and any assumptions and operations
related to the host device from the tests in SYCL/AOT.

Signed-off-by: Larsen, Steffen <[email protected]>
Co-authored-by: Sachkov, Alexey <[email protected]>
Pavel Chupin and others added 27 commits December 6, 2022 16:42
Can't reproduce current issue on HIP. Separate test execution logs to see
what's going on GPU target. Otherwise logs are overwritten.
#1402)

[SYCL] Reflect support of  AMD, NVIDIA GPU architectures as argument of the -fsycl-targets.
The change in intel/llvm is being reverted.
This commit adds tests for the sycl_oneapi_memcpy2d extension API.

Signed-off-by: Larsen, Steffen <[email protected]>
* Add test to validate correct split
* Disable execution of a test generated with -O0 option until crash issue is resolved
Calling link API is not supported for ESIMD kernels. Use simple kernel
instead, as it is not important for the purpose of the test.
This PR adapts t the matrix tests to the new API (unified API) and move
the old API tests to a new folder "Legacy".
It looks like python on windows is always python.exe and on some systems
we have python3.exe alias created manually.
This patch add new test which fixes the case for user-defined reductions
when WG size is bigger than the input data size.
… as default subgroup size unless specifically testing a given size (8 or 32 for example in some tests)
@stdale-intel stdale-intel deleted the private/stewartt/noSIMD8InlineASM branch December 29, 2022 06:36
ekilmer added a commit to trail-of-forks/instafix-llvm-test-suite that referenced this pull request Jun 10, 2025
Just one example, but others are likely similar (at least with same
stacktrace)

```
[1/7] : && /home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front --ld-path=instafix-lld-tool --for-linker=--fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld    -O3 -DNDEB
UG  tools/CMakeFiles/not.dir/not.cpp.o -o tools/not   && :
FAILED: tools/not
: && /home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front --ld-path=instafix-lld-tool --for-linker=--fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld    -O3 -DNDEBUG  tools/CMakeFiles/not.dir/not.cpp.o -o tools/not   && :
ClangLoc: /home/erickilmer/src/instafix-llvm/llvm/out/install/linux/bin/clang
Executing a non indexed phase: "/home/erickilmer/src/instafix/out/build/linux/instafix-lld/instafix-lld-tool" -z relro --hash-style=gnu --eh-frame-hdr -m elf_x86_64 -pie -dynamic-linker /lib64/ld-linux-x86-64.so.2 -o tools/not /lib/x86_64-linux-gnu/Scrt1.o /lib/x86_64-linux-gnu/crti.o /usr/lib/gcc/x86_64-linux-gnu/13/crtbeginS.o -L/usr/lib/gcc/x86_64-linux-gnu/13 -L/usr/lib/gcc/x86_64-linux-gnu/13/../../../../lib64 -L/lib/x86_64-linux-gnu -L/lib/../lib64 -L/usr/lib/x86_64-linux-gnu -L/usr/lib64 -L/lib -L/usr/lib --fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld tools/CMakeFiles/not.dir/not.cpp.o -lgcc --as-needed -lgcc_s --no-as-needed -lc -lgcc --as-needed -lgcc_s --no-as-needed /usr/lib/gcc/x86_64-linux-gnu/13/crtendS.o /lib/x86_64-linux-gnu/crtn.o
program_name: /home/erickilmer/src/instafix/out/build/linux/instafix-lld/instafix-lld-tool
input_file: /lib/x86_64-linux-gnu/Scrt1.o
input_file: /lib/x86_64-linux-gnu/crti.o
input_file: /usr/lib/gcc/x86_64-linux-gnu/13/crtbeginS.o
input_file: tools/CMakeFiles/not.dir/not.cpp.o
input_file: /usr/lib/gcc/x86_64-linux-gnu/13/crtendS.o
input_file: /lib/x86_64-linux-gnu/crtn.o
loc("/lib/x86_64-linux-gnu/libc.so":1:1): error: unexpected character
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.      Program arguments: /home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front --ld-path=instafix-lld-tool --for-linker=--fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld -O3 -DNDEBUG tools/CMakeFiles/not.dir/not.cpp.o -o tools/not
 #0 0x000064b890eb6d41 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /home/erickilmer/src/instafix-llvm/llvm/lib/Support/Unix/Signals.inc:804:11
 #1 0x000064b890eb723b PrintStackTraceSignalHandler(void*) /home/erickilmer/src/instafix-llvm/llvm/lib/Support/Unix/Signals.inc:880:1
 #2 0x000064b890eb49a6 llvm::sys::RunSignalHandlers() /home/erickilmer/src/instafix-llvm/llvm/lib/Support/Signals.cpp:105:5
 llvm#3 0x000064b890eb7a1d SignalHandler(int, siginfo_t*, void*) /home/erickilmer/src/instafix-llvm/llvm/lib/Support/Unix/Signals.inc:418:7
 llvm#4 0x00007c3845445330 (/lib/x86_64-linux-gnu/libc.so.6+0x45330)
 llvm#5 0x000064b883cd967c llvm::Value::getType() const /home/erickilmer/src/instafix-llvm/llvm/include/llvm/IR/Value.h:255:34
 llvm#6 0x000064b88fc554d2 llvm::CastInst::castIsValid(llvm::Instruction::CastOps, llvm::Value*, llvm::Type*) /home/erickilmer/src/instafix-llvm/llvm/include/llvm/IR/InstrTypes.h:623:31
 llvm#7 0x000064b890752419 llvm::ConstantExpr::getBitCast(llvm::Constant*, llvm::Type*, bool) /home/erickilmer/src/instafix-llvm/llvm/lib/IR/Constants.cpp:2325:3
 llvm#8 0x000064b887051e16 mlir::LLVM::detail::getLLVMConstant(llvm::Type*, mlir::Attribute, mlir::Location, mlir::LLVM::ModuleTranslation const&) /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:602:5
 llvm#9 0x000064b88705bb47 mlir::LLVM::ModuleTranslation::convertOneFunction(mlir::LLVM::LLVMFuncOp) /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:1465:25
llvm#10 0x000064b88705eea3 mlir::LLVM::ModuleTranslation::convertFunctions() /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:1804:16
llvm#11 0x000064b88706144d mlir::translateModuleToLLVMIR(mlir::Operation*, llvm::LLVMContext&, llvm::StringRef, bool) /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:2218:25
llvm#12 0x000064b883ba2fda instafix::Loader::LinkInstafixLLVM() /home/erickilmer/src/instafix/instafix/lib/instafix.cpp:837:7
llvm#13 0x000064b883bd9dc2 instafix::LLDLoader::NativeLinkAndJIT(int, llvm::ArrayRef<char const*>, bool) /home/erickilmer/src/instafix/instafix/lib/LLDLoader.cpp:42:27
llvm#14 0x000064b883b9d649 instafix::instafix_main(int, char**) /home/erickilmer/src/instafix/instafix/lib/instafix.cpp:264:32
llvm#15 0x000064b883b99992 main /home/erickilmer/src/instafix/bin/instafix-front/Main.cpp:25:3
llvm#16 0x00007c384542a1ca __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:74:3
llvm#17 0x00007c384542a28b call_init ./csu/../csu/libc-start.c:128:20
llvm#18 0x00007c384542a28b __libc_start_main ./csu/../csu/libc-start.c:347:5
llvm#19 0x000064b883b998a5 _start (/home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front+0x688a8a5)
Segmentation fault (core dumped)
```

with gdb stacktrace:

```
$ cd build
$ gdb --args /home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front --ld-path=instafix-lld-tool --for-linker=--fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld -O3 -DNDEBUG tools/CMakeFiles/not.dir/not.cpp.o -o tools/not
[...]
(gdb) r
[...]
Thread 1 "instafix-front" received signal SIGSEGV, Segmentation fault.
llvm::Value::getType (this=0x0) at /home/erickilmer/src/instafix-llvm/llvm/include/llvm/IR/Value.h:255
255	  Type *getType() const { return VTy; }
(gdb) bt
#0  llvm::Value::getType (this=0x0) at /home/erickilmer/src/instafix-llvm/llvm/include/llvm/IR/Value.h:255
#1  0x0000555567e9a4d2 in llvm::CastInst::castIsValid (op=llvm::Instruction::BitCast, S=0x0, DstTy=0x555569811470) at /home/erickilmer/src/instafix-llvm/llvm/include/llvm/IR/InstrTypes.h:623
#2  0x0000555568997419 in llvm::ConstantExpr::getBitCast (C=0x0, DstTy=0x555569811470, OnlyIfReduced=false) at /home/erickilmer/src/instafix-llvm/llvm/lib/IR/Constants.cpp:2325
llvm#3  0x000055555f296e16 in mlir::LLVM::detail::getLLVMConstant (llvmType=0x555569811470, attr=..., loc=..., moduleTranslation=...) at /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:602
llvm#4  0x000055555f2a0b47 in mlir::LLVM::ModuleTranslation::convertOneFunction (this=0x7fffffff3710, func=...) at /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:1465
llvm#5  0x000055555f2a3ea3 in mlir::LLVM::ModuleTranslation::convertFunctions (this=0x7fffffff3710) at /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:1804
llvm#6  0x000055555f2a644d in mlir::translateModuleToLLVMIR (module=0x5555697e32b0, llvmContext=..., name=..., disableVerification=false) at /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:2218
llvm#7  0x000055555bde7fda in instafix::Loader::LinkInstafixLLVM (this=0x55556979ea80) at /home/erickilmer/src/instafix/instafix/lib/instafix.cpp:837
llvm#8  0x000055555be1edc2 in instafix::LLDLoader::NativeLinkAndJIT (this=0x55556979ea80, argc=7, argv=..., exec=false) at /home/erickilmer/src/instafix/instafix/lib/LLDLoader.cpp:42
llvm#9  0x000055555bde2649 in instafix::instafix_main (argc=8, argv=0x7fffffffccc8) at /home/erickilmer/src/instafix/instafix/lib/instafix.cpp:264
llvm#10 0x000055555bdde992 in main (argc=8, argv=0x7fffffffccc8) at /home/erickilmer/src/instafix/bin/instafix-front/Main.cpp:25
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.