Skip to content

fix: handle url default db name #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Conversation

achrinza
Copy link
Member

@achrinza achrinza commented Aug 16, 2021

closes #610

Signed-off-by: Rifa Achrinza [email protected]

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@achrinza achrinza force-pushed the fix/handle-url-default-db-name branch 5 times, most recently from eaeac5e to c424d19 Compare August 16, 2021 06:16
Co-authored-by: Nico Flaig <[email protected]>
Signed-off-by: Rifa Achrinza <[email protected]>
@achrinza achrinza force-pushed the fix/handle-url-default-db-name branch from c8c962e to c28daf3 Compare September 12, 2021 14:35
@coveralls
Copy link

coveralls commented Sep 12, 2021

Pull Request Test Coverage Report for Build 1226722342

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 81.518%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/mongodb.js 2 4 50.0%
Totals Coverage Status
Change from base Build 1223945738: -0.1%
Covered Lines: 903
Relevant Lines: 1045

💛 - Coveralls

@achrinza achrinza marked this pull request as ready for review September 12, 2021 17:19
@achrinza achrinza merged commit 1d8a84b into master Sep 22, 2021
@achrinza achrinza deleted the fix/handle-url-default-db-name branch September 22, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db name is always admin if url is used without db
4 participants