Arduino: add Portfile for Arduino 1.8.8

[giansalvo]

Description

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.13.4
Xcode 9.3.1

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?

• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[macportsbot]

Travis Build #5279 Failed.

Lint results

--->  Verifying Portfile for Arduino
--->  0 errors and 0 warnings found.

Port Arduino fail on xcode10.2. Log
Port Arduino fail on xcode9.4. Log
Port Arduino success on xcode7.3. Log

[mojca]

I didn't take a closer look, but quite some fetching of files during build is going on. Is there any way to avoid that and pre-fetch & checksum all the files?

I don't want to push too hard because building this one is definitely not among the easiest ports. I just added some random trivial comments, it would be cool to get some feedback from more experienced users. Ihave absolutely no idea how difficult it is to actually build the Arduino IDE, I never tried it myself (I only used the downloaded binary so far).

@g5pw: do you have any comments / ideas about this one?

[mojca]

I would move this one to the build phase (and probably modify it a bit, perhaps something in the sense of build.cmd ant etc, but that's of secondary importance).

[giansalvo]

If I understand correctly, the build command is issued in the working directory. In this case the build command (ant) must run in ${worksrcpath}/build. How can I do this?

[mojca]

Btw: the build failures come from

java.nio.file.NoSuchFileException: /Library/Java/JavaVirtualMachines/jdk-10.0.1.jdk/MacOS

[giansalvo]

Btw: the build failures come from

java.nio.file.NoSuchFileException: /Library/Java/JavaVirtualMachines/jdk-10.0.1.jdk/MacOS

Thanks. The Arduino documentation says:

if you also have JDK 9 or 10 installed, you will need to select JDK 8

How can I set a dependency from JDK8?

[macportsbot]

Travis Build #5280 Failed.

Lint results

--->  Verifying Portfile for Arduino
--->  0 errors and 0 warnings found.

Port Arduino fail on xcode10.2. Log
Port Arduino fail on xcode9.4. Log
Port Arduino success on xcode7.3. Log

[giansalvo]

This version fails because Arduino 1.8.8 require JavaFX to compile which is not available in openjdk (it's available only in Oracle JDK). There is an open version called openjfx which is not available on MacPorts. Recently upstream modified the code to use jtouchbar 1.0.0 which is available open source, but I'm not able to integrate in the port process. I live here some references for someone that would like to help.
arduino/Arduino#8255
arduino/Arduino#8156
arduino/Arduino#8417
arduino/Arduino#8429
arduino/Arduino#8156

[macportsbot]

Travis Build #5286 Failed.

Lint results

--->  Verifying Portfile for Arduino
--->  0 errors and 0 warnings found.

Port Arduino fail on xcode10.2. Log
Port Arduino fail on xcode9.4. Log
Port Arduino fail on xcode8.3. Log

[macportsbot]

Travis Build #5303 Failed.

Lint results

--->  Verifying Portfile for Arduino
--->  0 errors and 0 warnings found.

Port Arduino fail on xcode10.2. Log
Port Arduino fail on xcode9.4. Log
Port Arduino fail on xcode8.3. Log
Port Arduino fail on xcode7.3. Log

[macportsbot]

Travis Build #5331 Passed.

Lint results

--->  Verifying Portfile for Arduino
--->  0 errors and 0 warnings found.

Port Arduino success on xcode10.2. Log
Port Arduino success on xcode9.4. Log
Port Arduino success on xcode8.3. Log
Port Arduino success on xcode7.3. Log

[macportsbot]

Travis Build #5336 Passed.

Lint results

--->  Verifying Portfile for Arduino
--->  0 errors and 0 warnings found.

Port Arduino success on xcode10.2. Log
Port Arduino success on xcode9.4. Log
Port Arduino success on xcode8.3. Log
Port Arduino success on xcode7.3. Log

[mojca]

Someone would usually ask you to squash the commits, but I did that now.

Also, since there is no single other port in the electronics, I moved it to devel. I don't know if this is the best category, but if we introduce electronics, it would only make sense to do so if we move a bunch of other ports there as well.

While squashing the commits I probably screwed up with commit author's email identity. I would have merged this already, but maybe you can give your final thumbs up or comments if I should fix something myself. Other than that it looks ready to go.

[macportsbot]

Travis Build #5339 Passed.

Lint results

--->  Verifying Portfile for Arduino
--->  0 errors and 0 warnings found.

Port Arduino success on xcode10.2. Log
Port Arduino success on xcode9.4. Log
Port Arduino success on xcode8.3. Log
Port Arduino success on xcode7.3. Log

[mojca]

I would have one further objection, but I don't want to go too deep into nitpicking, and my suggestion would be to try to fix this later, else it might take "forever" to get this in. This port is downloading files during the build, which is kind-of against our general policy to first fetch everything in fetch phase, then checksum it, and finally build without any further downloads. I would vote for accepting this, but trying to follow the policy more closely some time soon in the future.

I also suspect that the supported architectures and OS versions are limited to something like intel & >= 10.7, but I didn't test anything.

[giansalvo]

I agree to merge the changes and after I'll investigate the fetch problem and the supported systems.