This repository was archived by the owner on Dec 19, 2019. It is now read-only.
Added HTML renderer for description and short description #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paliarush
reviewed
Aug 8, 2018
| QUERY; | ||
| $response = $this->graphQlQuery($query); | ||
|
|
||
| self::assertContains($assertionCmsBlockText, $response['products']['items'][0]['description']); |
There was a problem hiding this comment.
Optionally, but would be nice to make sure no {{ or }} left in the description.
paliarush
approved these changes
Aug 8, 2018
Signed-off-by: vitaliyboyko <[email protected]>
…ps://github.com/magento/graphql-ce into rendered-attributes-product
Will be added in scope of further PR's Signed-off-by: vitaliyboyko <[email protected]>
naydav
pushed a commit
that referenced
this pull request
Sep 17, 2018
paliarush
reviewed
Sep 18, 2018
| return null; | ||
| }; | ||
| return $this->valueFactory->create($result); | ||
| throw new GraphQlInputException(__('"model" value should be specified')); |
There was a problem hiding this comment.
Should be \LogicException. Related discussion https://github.com/magento/graphql-ce/pull/132/files/a4c941e5fa7215e036198bd61c241434c03036ac..d86087487c0d505400c82d7e18dc6e0d6238464c
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 18, 2018
magento-engcom-team
added a commit
that referenced
this pull request
Nov 8, 2018
- Merge Pull Request magento-engcom/import-export-improvements#140 from maxalmonte14/import-export-improvements:improvement/supress_undefined_property_error - Merged commits: 1. 9a7fa4c 2. d0c4c64 3. fab32c6
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 8, 2018
naydav
pushed a commit
that referenced
this pull request
Jun 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves output for description and shord_description of a product. Previously we just had a raw output. Now, if you use some directive (upon inserting a block into the description or so), its contents are rendered.
Fixed Issues (if relevant)
Manual testing scenarios
2.3-developbranch (optionally: with sample data installed)