Skip to content

Setup composer 1.10.10 for FT #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Setup composer 1.10.10 for FT #289

merged 2 commits into from
Sep 9, 2020

Conversation

BaDos
Copy link
Contributor

@BaDos BaDos commented Sep 8, 2020

Description

The fix kylekatarnls/update-helper#9

Fixed Issues (if relevant)

  1. magento/magento-cloud-docker#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Release notes

For user-facing changes, add a meaningful release note. For examples, see Magento Cloud Docker release notes.

Associated documentation updates

Add link to Magento DevDocs PR or Issue, if needed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful release notes and documentation
  • All commits are accompanied by meaningful commit messages

.travis.yml Outdated
@@ -82,6 +82,10 @@ jobs:
env:
- TEST_SUITE=functional

before_install:
# https://github.com/kylekatarnls/update-helper/issues/9
- travis_retry composer self-update 1.10.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose making it more flexible with env variable, if not exists - use the latest version

Copy link
Contributor Author

@BaDos BaDos Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be removed when this issue is resolved kylekatarnls/update-helper#9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I will add env :)

@BaDos BaDos requested a review from shiftedreality September 8, 2020 18:08
@shiftedreality shiftedreality merged commit 942796c into develop Sep 9, 2020
@shiftedreality shiftedreality deleted the tmp-fix branch September 9, 2020 15:00
@m2-community-project m2-community-project bot added Progress: done and removed Progress: review PR/issue status labels Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not parse version constraint ^2.0.x-dev: Invalid version string "^2.0.x-dev"
3 participants