MCLOUD-6898: Add option to customize port for MailHog #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -138,8 +138,8 @@ services: | |||
| image: 'mailhog/mailhog:latest' | |||
| restart: always | |||
There was a problem hiding this comment.
Please remove restart: always since it causes issues
shiftedreality
suggested changes
Sep 14, 2020
src/Compose/ProductionBuilder.php
Outdated
| $this->serviceFactory->getDefaultVersion(ServiceInterface::SERVICE_MAILHOG), | ||
| [ | ||
| 'ports' => [ | ||
| ($config->getMailHogSmtpPort() ?: '1025').':1025', |
There was a problem hiding this comment.
Move defaults port to source where http ports located
arhiopterecs
previously approved these changes
Sep 15, 2020
shiftedreality
approved these changes
Sep 15, 2020
arhiopterecs
approved these changes
Sep 15, 2020
m2-community-project
bot
added
Progress: ready for testing
and removed
Progress: review
|
QA approved |
m2-community-project
bot
added
Progress: done
and removed
Progress: ready for delivery
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added options to configure HTTP and SMTP ports for MailHog
Fixed Issues (if relevant)
Manual testing scenarios
Covered with Integration and Functional tests
Release notes
Added MailHog configuration options to the ece-docker build:compose command to customize the HTTP and SMTP ports, and to disable MailHog. See Set up email.
Associated documentation updates
magento/devdocs#7860
Contribution checklist