[New Rule] Static methods SHOULD NOT be used

[lenaorobei]

Rule

The use of static methods is discouraged.

Reason

Source: Magento Technical Guidelines.

Plugins cannot be used with static methods, because static methods cannot be intercepted.
As a result, It hurts extensibility.

Implementation

• Subscribe to the T_STATIC token.
• If T_FUNCTION is found right to it raise a warning.

[larsroettig]

Hi i will work on this at next weekend

[YevSent]

This rule should not include tests which use PHPUnit because all assert..., once(), atLeast(), etc. are static methods.

[paliarush]

@joni-jones I believe this is not relevant because the proposed sniff is looking for declaration of the static tests, not usage. Additionally, in the recent versions of PHPUnit all this methods are not invoked statically.