Skip to content

AC-1740: Add rectorphp as a dependency to magento-coding-standard #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Nov 23, 2021
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d3dc3f4
AC-1740: Add rectorphp as a dependency to magento-coding-standard
eliseacornejo Nov 16, 2021
874884f
AC-1740: Add rectorphp as a dependency to magento-coding-standard
eliseacornejo Nov 16, 2021
cdf641e
AC-1740: Add rectorphp as a dependency to magento-coding-standard
eliseacornejo Nov 16, 2021
b669d8c
AC-1740: Add rectorphp as a dependency to magento-coding-standard
eliseacornejo Nov 16, 2021
372da91
AC-1740: Add rectorphp as a dependency to magento-coding-standard
eliseacornejo Nov 16, 2021
503878b
AC-1740: Add rectorphp as a dependency to magento-coding-standard
eliseacornejo Nov 16, 2021
01e243e
AC-1740: Add rectorphp as a dependency to magento-coding-standard
eliseacornejo Nov 16, 2021
cda190f
AC-1740: Add rectorphp as a dependency to magento-coding-standard
eliseacornejo Nov 16, 2021
a4595df
AC-1740: Add rectorphp as a dependency to magento-coding-standard
eliseacornejo Nov 17, 2021
f7fdb02
AC-1740: Add rectorphp as a dependency to magento-coding-standard
eliseacornejo Nov 17, 2021
a18b7f2
AC-1740: Add rectorphp as a dependency to magento-coding-standard
eliseacornejo Nov 18, 2021
02eb5d8
Merge branch 'develop' of github.com:magento/magento-coding-standard …
eliseacornejo Nov 18, 2021
a5ad00b
AC-1740
eliseacornejo Nov 19, 2021
2915b71
Merge branch 'develop' of github.com:magento/magento-coding-standard …
eliseacornejo Nov 19, 2021
5ebccb0
AC-1740: Add rectorphp as a dependency to magento-coding-standard and…
eliseacornejo Nov 19, 2021
d463a5a
AC-1740: Add rectorphp as a dependency to magento-coding-standard and…
eliseacornejo Nov 19, 2021
4b3df3e
AC-1740: Add rectorphp as a dependency to magento-coding-standard and…
eliseacornejo Nov 22, 2021
692b23d
AC-1740: Add rectorphp as a dependency to magento-coding-standard and…
eliseacornejo Nov 22, 2021
a10e77c
AC-1740: Add rectorphp as a dependency to magento-coding-standard and…
eliseacornejo Nov 23, 2021
856d8ca
AC-1740: Add rectorphp as a dependency to magento-coding-standard and…
eliseacornejo Nov 23, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,20 @@ jobs:

- name: Run ESLint
run: npm run eslint -- eslint/rules
rector:
runs-on: ubuntu-latest
name: Rector tests

steps:
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: '16'

- uses: actions/checkout@v2

- name: Install dependencies
run: composer install

- name: Run rector
run: vendor/bin/rector process --dry-run
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"squizlabs/php_codesniffer": "^3.6",
"webonyx/graphql-php": "^14.9",
"ext-simplexml": "*",
"ext-dom": "*"
"ext-dom": "*",
"rector/rector": "^0.12.4"
},
"require-dev": {
"phpunit/phpunit": "^9.5.8"
Expand Down
126 changes: 125 additions & 1 deletion composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

69 changes: 69 additions & 0 deletions rector.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
<?php

declare(strict_types=1);

use Rector\Core\Configuration\Option;
use Rector\Core\ValueObject\PhpVersion;
use Rector\Php80\Rector\Catch_\RemoveUnusedVariableInCatchRector;
use Rector\Php80\Rector\FuncCall\ClassOnObjectRector;
use Rector\Php80\Rector\FuncCall\Php8ResourceReturnToObjectRector;
use Rector\Php80\Rector\FuncCall\TokenGetAllToObjectRector;
use Rector\Php80\Rector\FunctionLike\UnionTypesRector;
use Rector\Php80\Rector\Identical\StrEndsWithRector;
use Rector\Php80\Rector\Identical\StrStartsWithRector;
use Rector\Php80\Rector\NotIdentical\StrContainsRector;
use Rector\Php80\Rector\Switch_\ChangeSwitchToMatchRector;
use Rector\Php80\Rector\Ternary\GetDebugTypeRector;
use Rector\Php81\Rector\Class_\MyCLabsClassToEnumRector;
use Rector\Php81\Rector\Class_\SpatieEnumClassToEnumRector;
use Rector\Php81\Rector\ClassConst\FinalizePublicClassConstantRector;
use Rector\Php81\Rector\ClassMethod\NewInInitializerRector;
use Rector\Php81\Rector\FunctionLike\IntersectionTypesRector;
use Rector\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector;
use Rector\Php81\Rector\Property\ReadOnlyPropertyRector;
use Rector\Set\ValueObject\SetList;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
// get parameters
$parameters = $containerConfigurator->parameters();
$parameters->set(Option::PATHS, [
__DIR__ . '/Magento2',
__DIR__ . '/Magento2Framework',
__DIR__ . '/PHP_CodeSniffer'
]);
$parameters->set(Option::BOOTSTRAP_FILES, [__DIR__ . '/vendor/squizlabs/php_codesniffer/autoload.php']);

$parameters->set(Option::PHP_VERSION_FEATURES, PhpVersion::PHP_80);
$parameters->set(Option::PHP_VERSION_FEATURES, PhpVersion::PHP_81);

$parameters->set(Option::SKIP, [
ReadOnlyPropertyRector::class,
StrContainsRector::class,
UnionTypesRector::class,
StrStartsWithRector::class,
StrEndsWithRector::class,
FinalizePublicClassConstantRector::class,
RemoveUnusedVariableInCatchRector::class,
ClassOnObjectRector::class,
Php8ResourceReturnToObjectRector::class,
TokenGetAllToObjectRector::class,
GetDebugTypeRector::class,
ChangeSwitchToMatchRector::class,
NewInInitializerRector::class,
IntersectionTypesRector::class,
MyCLabsMethodCallToEnumConstRector::class,
MyCLabsClassToEnumRector::class,
SpatieEnumClassToEnumRector::class
]);

// Define what rule sets will be applied
$containerConfigurator->import(SetList::PHP_80);
$containerConfigurator->import(SetList::PHP_81);

// get services (needed for register a single rule)
// $services = $containerConfigurator->services();

// register a single rule
// $services->set(TypedPropertyRector::class);
};