Show prefix/suffix setting ignored when set to No

[theodorhanu]

Preconditions and environment

• Magento 2.4.7-p4

Steps to reproduce

Example:

1. Set the show prefix/suffix to Required
2. Create a customer and set its prefix
3. Place an order with an address containing the prefix/suffix filled
4. Set the Show prefix/suffix back to no
5. Visit the order page in admin area and notice the Customer Name under Account Information having prefix shown

Expected result

The prefix/suffix should be stripped depending on config setting

Actual result

When set to No, the prefix/suffix is still shown if it exists at the order level

Additional information

Issue seems to reside in the way isVisibleCustomerPrefix / isVisibleCustomerSuffix checks the value of the setting (comparison with type checking ). When set to No, the value returned by $this->scopeConfig->getValue() is null rather than an empty string.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @theodorhanu. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

HI @theodorhanu,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

prefix/suffix is still shown for customer under account information and it looks like an expected behaviour because while creating customer the prefix/suffix are required values and those values are getting stored into database.Could you please let us know if we are missing anything.

Thanks.

[theodorhanu]

Hi @engcom-Bravo
Thanks for checking.
If the shop owner does not want to show the prefix/suffix anymore, setting the value to No has no effect. The Account Information issue in order overview is just an example. The same \Magento\Sales\Model\Order->getCustomerName method is used in various places, another one of them being order confirmation email.
A case where the setting is properly taken into account is the Address formatting. If you look closely to your screenshot, you'll notice the prefix is not included in customer name.
Therefore, setting the Shop prefix/suffix config value to No I expect that is taken into account everywhere the setting is used, regardless if the customer filled in the information at some point in time.
A simple fix would be to remove the strict type checking in isVisibleCustomerPrefix / isVisibleCustomerSuffix methods of Order model.