Simplify version constraint for the php-amqplib/php-amqplib package, …

[hostep]

…now that the php extension sockets is considered required for Magento.

Description (*)

As requested in #27200 by @melnikovi, here's a pull request which simplifies the version constraint on the php-amqplib/php-amqplib package now that the php extension sockets is considered required for Magento 2.

Version 2.7 of php-amqplib/php-amqplib didn't require the sockets extension, but since version 2.8.1 it became required.

This prevents developers from accidentally updating the composer.lock file inside this github repo as well as inside projects where it changes the version of php-amqplib/php-amqplib based on if they have the sockets extension installed or not, which can be quite annoying to deal with.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Dependency php-amqplib/php-amqplib vs php extension sockets causes inconsistent composer.lock file #27200

Manual testing scenarios (*)

1. Have a PHP installation where the sockets extension is not installed
2. Try to install Magento using composer after this fix, it should no longer work.

Questions or comments

I'm not entirely sure, but should we also define ext-sockets in the composer.json file of Magento 2? I'm a bit confused about the comment from @dobooth if the list of extensions in devdocs is solely generated from the composer.json file, or from all composer dependencies?

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @hostep. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[hostep]

Not really needed to run any tests here I believe, since the composer.lock file contains no real changes, so no dependencies are being changed here.

[ihor-sviziev]

@magento run all tests

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7626 has been created to process this Pull Request

[ihor-sviziev]

@hostep i think we don’t need to add dependency to sockets extension as magento actually not depends on it directly, only through library

[lenaorobei]

Commit was cherry-picked and merge to 2.4.0 is in progress.

[engcom-Alfa]

Hi, @hostep. Could you resolve merge conflicts?

Pull Request state was updated. Re-review required.

[hostep]

@engcom-Alfa: since @lenaorobei already merged this in the release branch for 2.4.0, there is no need anymore for this PR, right? We can probably close it?

[lenaorobei]

@hostep thanks for this contribution! Yes, it was delivered to 2.4.0.

[m2-assistant]

Hi @hostep, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.