Update npm packages to recently compatible #33515

mrtuvn · 2021-07-17T11:48:25Z

Description (*)

Update packages to newer version (grunt, some grunt plugins .v.v).
Restrict less according to version lessjs from lib/web directory.

Related Pull Requests

https://github.com/magento/partners-magento2-infrastructure/pull/61

Fixed Issues (if relevant)

Fixes Update npm packages to the latest versions #33512

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-07-17T11:48:27Z

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mrtuvn · 2021-07-17T14:40:55Z

@magento run all tests

magento-automated-testing · 2021-07-17T14:41:03Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-07-18T00:56:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-07-18T11:40:14Z

@magento run all tests

magento-automated-testing · 2021-07-18T11:40:21Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-07-18T23:47:06Z

@magento run Unit Tests, Static Tests, Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2021-07-18T23:47:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-07-19T07:30:19Z

@magento run Unit Tests, Static Tests

magento-automated-testing · 2021-07-19T07:30:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-07-20T04:18:41Z

@magento run Unit Tests, Static Tests

magento-automated-testing · 2021-07-20T04:18:45Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-07-21T06:40:54Z

@magento run Unit Tests, Static Tests

magento-automated-testing · 2021-07-21T06:40:57Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-07-21T10:32:50Z

@sivaschenko, could you provide some info on why static & unit tests are failing w/o any failures in reports?

sivaschenko · 2021-07-23T12:20:10Z

@mrtuvn @ihor-sviziev here are the errors from the build log:

Unit tests:

grunt spec
Loading "Gruntfile.js" tasks...ERROR
SyntaxError: Unexpected token {
Warning: Task "spec" not found.� Use --force to continue.

Static tests:

grunt static:test
Loading "Gruntfile.js" tasks...ERROR
SyntaxError: Unexpected token {
Running "static:test" (static) task
...
Warning: Cannot read property 'test' of undefined� Use --force to continue.
Aborted due to warnings.

Also, there is a warning, it will be nice is this can be updated as well:

Magento\Test\Legacy\PhtmlTemplateTest::testJsComponentsAreProperlyInitializedInXMagentoInitAttribute
assertNotRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertDoesNotMatchRegularExpression() instead

ihor-sviziev

Please fix test failures

magento-automated-testing · 2021-09-01T15:01:47Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-09-01T15:42:49Z

@magento run Static Tests, Unit Tests

magento-automated-testing · 2021-09-01T15:43:18Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-09-01T17:02:35Z

@magento run Static Tests, Unit Tests

magento-automated-testing · 2021-09-01T17:03:02Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-09-01T18:59:12Z

@magento run Static Tests, Unit Tests

magento-automated-testing · 2021-09-01T18:59:39Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-09-01T19:47:35Z

@magento run Static Tests, Unit Tests

magento-automated-testing · 2021-09-01T19:48:03Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-09-01T20:27:43Z

@magento run Static Tests, Unit Tests

magento-automated-testing · 2021-09-01T20:28:12Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-09-01T22:04:12Z

@magento run Static Tests, Unit Tests

magento-automated-testing · 2021-09-01T22:04:41Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-09-02T04:35:21Z

@magento run Static Tests, Unit Tests

magento-automated-testing · 2021-09-02T04:35:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-09-02T05:29:01Z

@magento run Static Tests, Unit Tests

magento-automated-testing · 2021-09-02T05:29:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-09-02T06:52:28Z

@magento run all tests

magento-automated-testing · 2021-09-02T06:52:58Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

m2-assistant · 2021-09-02T10:12:56Z

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Jul 17, 2021

mrtuvn added the Project: Platform Health label Jul 21, 2021

mrtuvn requested a review from GrimLink July 22, 2021 10:22

ihor-sviziev self-assigned this Jul 26, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jul 26, 2021

ihor-sviziev requested changes Jul 26, 2021

View reviewed changes

m2-community-project bot removed the Progress: review label Jul 26, 2021

ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: review labels Jul 26, 2021

m2-community-project bot added Progress: needs update and removed Progress: review labels Jul 26, 2021

Den4ik self-requested a review July 27, 2021 04:10

andrewbess force-pushed the update-npm-packages branch from 8468469 to c90c369 Compare September 1, 2021 15:42

andrewbess force-pushed the update-npm-packages branch from c90c369 to 9825f47 Compare September 1, 2021 17:02

andrewbess force-pushed the update-npm-packages branch from b36c8df to 14731da Compare September 1, 2021 20:26

Update npm packages to recently compatible

8f6ceb9

andrewbess force-pushed the update-npm-packages branch from 6b04919 to 8f6ceb9 Compare September 2, 2021 06:52

ihor-sviziev approved these changes Sep 2, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Sep 2, 2021

eduard13 approved these changes Sep 2, 2021

View reviewed changes

andrewbess merged commit 5682fa3 into magento:platform-health Sep 2, 2021

Update npm packages to recently compatible #33515

Update npm packages to recently compatible #33515

Uh oh!

Conversation

mrtuvn commented Jul 17, 2021 • edited by andrewbess Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jul 17, 2021

Uh oh!

mrtuvn commented Jul 17, 2021

Uh oh!

magento-automated-testing bot commented Jul 17, 2021

Uh oh!

magento-automated-testing bot commented Jul 18, 2021

Uh oh!

mrtuvn commented Jul 18, 2021

Uh oh!

magento-automated-testing bot commented Jul 18, 2021

Uh oh!

mrtuvn commented Jul 18, 2021

Uh oh!

magento-automated-testing bot commented Jul 18, 2021

Uh oh!

mrtuvn commented Jul 19, 2021

Uh oh!

magento-automated-testing bot commented Jul 19, 2021

Uh oh!

mrtuvn commented Jul 20, 2021

Uh oh!

magento-automated-testing bot commented Jul 20, 2021

Uh oh!

mrtuvn commented Jul 21, 2021

Uh oh!

magento-automated-testing bot commented Jul 21, 2021

Uh oh!

ihor-sviziev commented Jul 21, 2021

Uh oh!

sivaschenko commented Jul 23, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

magento-automated-testing bot commented Sep 1, 2021

Uh oh!

andrewbess commented Sep 1, 2021

Uh oh!

magento-automated-testing bot commented Sep 1, 2021

Uh oh!

andrewbess commented Sep 1, 2021

Uh oh!

magento-automated-testing bot commented Sep 1, 2021

Uh oh!

andrewbess commented Sep 1, 2021

Uh oh!

magento-automated-testing bot commented Sep 1, 2021

Uh oh!

andrewbess commented Sep 1, 2021

Uh oh!

magento-automated-testing bot commented Sep 1, 2021

Uh oh!

andrewbess commented Sep 1, 2021

Uh oh!

magento-automated-testing bot commented Sep 1, 2021

Uh oh!

andrewbess commented Sep 1, 2021

Uh oh!

magento-automated-testing bot commented Sep 1, 2021

Uh oh!

andrewbess commented Sep 2, 2021

Uh oh!

magento-automated-testing bot commented Sep 2, 2021

Uh oh!

andrewbess commented Sep 2, 2021

Uh oh!

magento-automated-testing bot commented Sep 2, 2021

Uh oh!

mrtuvn commented Jul 17, 2021 •

edited by andrewbess

Loading