Skip to content

Release/1.9.0 #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 4, 2025
Merged

Release/1.9.0 #165

merged 7 commits into from
Jun 4, 2025

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Jun 4, 2025

Description of the Change

Version bump and prep for the 1.9.0 release

Closes #163

How to test the Change

Verify all file changes look accurate and tests pass

Changelog Entry

n/a

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 1.9.0 milestone Jun 4, 2025
@dkotter dkotter self-assigned this Jun 4, 2025
@dkotter
Copy link
Collaborator Author

dkotter commented Jun 4, 2025

@iamdharmesh In testing the final release, noticing a few things with user sync that we'll probably want to fix.

First, if I've never configured the user sync settings before (which will be the case for everyone as this is new), the only things checked are Sync as Pending and Roles to sync is set to Subscriber. If I don't change Enable auto user sync or Sync existing contacts only but I change something else and save (or don't change anything and save), it will automatically select Enable auto user sync and Sync existing contacts only, even though I didn't choose those. I can then uncheck those and it saves properly but I'm guessing we have some code that defaults to those being checked if we have no value.

And then if Sync existing contacts only is checked, the User sync settings banner doesn't extend across the container:

Screenshot 2025-06-04 at 9 30 23 AM

@iamdharmesh
Copy link
Collaborator

@dkotter both issues are handled in 8cb244d, could you please help to check it once. Thanks!

@dkotter dkotter requested a review from vikrampm1 June 4, 2025 19:01
@dkotter
Copy link
Collaborator Author

dkotter commented Jun 4, 2025

@vikrampm1 Couple more thoughts on things I think we could improve in regards to user sync, though I'll leave it up to you to decide if these sound important enough to open a tracking issue (maybe just a single UX type issue?).

  1. Might be nice to have a sentence or two that shows at the top of the User Sync settings page that better explains what the user sync will do / is for. It's fairly straightforward based on the settings there but I think some people may be confused and not completely understand the feature
  2. After a sync completes, if you're still on the settings page, the status message goes away and a success message shows. This message though is at the top of the screen and isn't immediately visible if you're scrolled down. Would be great to auto scroll back up to make it clear the process completed
  3. If there are errors, we output those in a table at the bottom of the settings page but it isn't clear those exist. I think updating the admin notice we show to link to that error section when errors happen would help

@dkotter dkotter merged commit b7f7e3b into develop Jun 4, 2025
11 checks passed
@dkotter dkotter deleted the release/1.9.0 branch June 4, 2025 19:44
@vikrampm1
Copy link
Collaborator

@dkotter agreed on all the three. Seems like they're all minor changes so I will open a follow-up UX issue to tackle all three.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release version 1.9.0
3 participants