chore: fix new clippy warnings causing build errors #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencher Report
shanecelis
added a commit
to shanecelis/bevy_mod_scripting
that referenced
this pull request
Jul 14, 2025
This is a combination of 68 commits. hack: It compiles. hack: Compile with lua54 feature. refactor: Accept Handle<ScriptAsset> in ScriptComponents. feature: Handle static scripts. bug: Fix rhea and static script unloading. feature: Add ScriptSetttings to loader. This introduces a serde dependency though. :( test: Prep tests to run. feature: Add DisplayProxy. Refactor continues. refactor: Bring test harness in line. test: Tests are running! test: Make test runnable without rhai. excise: Remove ScriptMetadata and ScriptEvent. We don't need them since asset's know their language. excise: Drop Script::asset field. It's a duplicate with Script::id now. chore: fix build problem in xtask perf: Can create_or_update_script w/o clone. feature: Try to use the entities. hack: It compiles but idk why. I fought with HandlerContext trying to add a Query to it for the longest time. hack: Compiles but doesn't run well. Log is flooded with these two lines: ```log 2025-06-28T11:46:54.321715Z ERROR bevy_mod_scripting_core::handler: Rhai: Failed to query entities with scripts: Cannot claim access to base type: Global. The base is already claimed by something else in a way which prevents safe access. Location: "/Users/shane/Projects/bevy_mod_scripting/crates/bevy_mod_scripting_core/src/extractors.rs:337". Context: Could not claim exclusive world access 2025-06-28T11:46:54.322046Z ERROR bevy_mod_scripting_core::handler: Lua: Failed to query entities with scripts: Cannot claim access to base type: Global. The base is already claimed by something else in a way which prevents safe access. Location: "/Users/shane/Projects/bevy_mod_scripting/crates/bevy_mod_scripting_core/src/extractors.rs:337". Context: Could not claim exclusive world access ``` feature: Use SharedContext(P::C) for global context. feature: GOL works with SharedContext. feature: Works with ScriptContextProvider trait. refactor: It's all coming together now. bug: Make per-entity work with static scripts. doc: Clarify EntityContext. Hide internal struct. chore: fix new clippy warnings causing build errors (makspll#428) partial: Add domain handling. feature: Add ScriptContextProvider::hash member. feature: Call labels on a per-context basis. doc: Explain call per-context rationale. feature: More ScriptComponentProvider<P> variants. chore: Restore commented log plugin. test: Remove script_id_generator parameter. test: Remove metadata tests. refactor: Prefer Option<Entity> vs Entity::from_raw(0). bug: Scripts w/o AssetServer didn't work. Now you can add scripts via `Assets<ScriptAsset>` or the `AssetServer`. test: Fix tests. perf: Avoid cloning script content when possible. doc: Document script::Or. refactor: Unscore unused parameters in context providers. chore: Fix it, Clippy! doc: Add note about ScriptContext::hash(). test: Fix/refactor tests. feature: Remove todo! & impl supported extensions. Implement the ConfigureScriptAssetSettings again. chore: Make core tests compile. test: It compiles! 8 test failures. test: All tests passing except 3. partial: Handle event rework. feature: Add iter() to ScriptContextProvider<P>. refactor: Rework event handling. partial: Collecting contexts. partial: More handler event mulling. feature: New event handler. Early exit. Fewer allocations. No querying unless necessary. feature: Add remove() to ScriptContextProvider<P>. feature: Make DeleteScript delete contexts too. feature: Add EntityScriptIdContext and ContextKey. feature: Rename iter() to values(). feature: Add iter() to ScriptContextProvider<P>. feature: Handle Recipient::ScriptId fully. Static scripts included. Fewer clones. refactor: Move ContextKey to its own file. feature: Made Domain(u64). refactor: Weave ContextKey in. It'd be nice if ContextKey had a Handle<ScriptAsset> just for logging purposes. refactor: Use ContextKey. Tests pass! refactor: Use ContextKey instead of ScriptId. chore: Clean up warnings. bug: Fix game of life. feature: Add prelude. I like explicit imports, but I'm trying to make the code in mdbook runnable, just so it is easier to maintain, and it feels like it'd be a mess without a prelude. doc: Update book. A few code refactors to make book writing easier. feature: Add ConfigureScriptAssetSettings to prelude.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes new clippy errors accumulated from newer rustup versions.
Also finally pin the toolchain so this doesn't happen until explicitly updated