Skip to content

feat!: Use the Handles, Luke! (#427) #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 14, 2025
Merged

feat!: Use the Handles, Luke! (#427) #444

merged 7 commits into from
Aug 14, 2025

Conversation

makspll
Copy link
Owner

@makspll makspll commented Aug 10, 2025

Summary

Copy link

semanticdiff-com bot commented Aug 10, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  assets/tests/add_system/added_systems_run_in_parallel.lua  85% smaller
  crates/bevy_mod_scripting_functions/src/lib.rs  80% smaller
  assets/tests/add_system/system_with_parameters.lua  75% smaller
  assets/tests/add_system/system_cannot_access_unspecified_resource_in_non_exclusive_system.lua  72% smaller
  assets/tests/add_system/adds_system_in_correct_order.lua  66% smaller
  crates/bevy_mod_scripting_core/src/bindings/allocator.rs  66% smaller
  assets/tests/add_system/system_can_access_unspecified_resource_in_exclusive_system.lua  63% smaller
  crates/testing_crates/test_utils/src/test_data.rs  59% smaller
  crates/bevy_mod_scripting_core/src/bindings/script_system.rs  58% smaller
  crates/testing_crates/test_utils/src/test_plugin.rs  56% smaller
  crates/bevy_mod_scripting_core/src/extractors.rs  47% smaller
  tests/script_tests.rs  37% smaller
  crates/languages/bevy_mod_scripting_lua/src/lib.rs  34% smaller
  crates/bevy_mod_scripting_core/src/error.rs  29% smaller
  crates/testing_crates/script_integration_test_harness/src/lib.rs  29% smaller
  crates/bevy_mod_scripting_core/src/bindings/function/script_function.rs  25% smaller
  crates/bevy_mod_scripting_core/src/bindings/script_component.rs  25% smaller
  benches/benchmarks.rs  25% smaller
  crates/ladfile_builder/src/plugin.rs  24% smaller
  crates/ladfile_builder/src/lib.rs  20% smaller
  crates/languages/bevy_mod_scripting_rhai/src/lib.rs  18% smaller
  crates/bevy_mod_scripting_core/src/asset.rs  15% smaller
  crates/bevy_mod_scripting_core/src/commands.rs  14% smaller
  crates/bevy_mod_scripting_core/src/lib.rs  13% smaller
  crates/bevy_mod_scripting_core/src/bindings/globals/mod.rs  11% smaller
  crates/bevy_mod_scripting_core/src/handler.rs  10% smaller
  crates/bevy_mod_scripting_functions/src/core.rs  9% smaller
  crates/bevy_mod_scripting_core/src/event.rs  8% smaller
  crates/bevy_mod_scripting_core/src/bindings/pretty_print.rs  6% smaller
  crates/bevy_mod_scripting_core/src/bindings/schedule.rs  4% smaller
  crates/bevy_mod_scripting_core/src/bindings/world.rs  1% smaller
  Cargo.toml Unsupported file format
  assets/reload.lua  0% smaller
  assets/tests/add_system/added_systems_run_in_parallel.rhai Unsupported file format
  assets/tests/add_system/adds_system_in_correct_order.rhai Unsupported file format
  assets/tests/add_system/system_can_access_unspecified_resource_in_exclusive_system.rhai Unsupported file format
  assets/tests/add_system/system_cannot_access_unspecified_resource_in_non_exclusive_system.rhai Unsupported file format
  assets/tests/add_system/system_with_parameters.rhai Unsupported file format
  assets/tests/api_availability/api_available_on_callback_and_on_load.lua  0% smaller
  assets/tests/api_availability/api_available_on_callback_and_on_load.rhai Unsupported file format
  assets/tests/handle/handle_asset_path_when_script_loaded.lua  0% smaller
  assets/tests/lifecycle/default/entity_script/callback/callback.lua  0% smaller
  assets/tests/lifecycle/default/entity_script/callback/scenario.txt Unsupported file format
  assets/tests/lifecycle/default/entity_script/loading/lifecycle.lua  0% smaller
  assets/tests/lifecycle/default/entity_script/loading/scenario.txt Unsupported file format
  assets/tests/lifecycle/default/multi_language/multi_lang.lua  0% smaller
  assets/tests/lifecycle/default/multi_language/multi_lang.rhai Unsupported file format
  assets/tests/lifecycle/default/multi_language/scenario.txt Unsupported file format
  assets/tests/lifecycle/default/static_script/callback/callback.lua  0% smaller
  assets/tests/lifecycle/default/static_script/callback/scenario.txt Unsupported file format
  assets/tests/lifecycle/default/static_script/loading/lifecycle.lua  0% smaller
  assets/tests/lifecycle/default/static_script/loading/scenario.txt Unsupported file format
  assets/tests/lifecycle/shared/entity_script/lifecycle.lua  0% smaller
  assets/tests/lifecycle/shared/entity_script/lifecycle_b.lua  0% smaller
  assets/tests/lifecycle/shared/entity_script/scenario.txt Unsupported file format
  assets/tests/lifecycle/shared/static_script/lifecycle.lua  0% smaller
  assets/tests/lifecycle/shared/static_script/lifecycle_b.lua  0% smaller
  assets/tests/lifecycle/shared/static_script/scenario.txt Unsupported file format
  assets/tests/scenario.txt Unsupported file format
  crates/bevy_mod_scripting_core/Cargo.toml Unsupported file format
  crates/bevy_mod_scripting_core/src/bindings/globals/core.rs  0% smaller
  crates/bevy_mod_scripting_core/src/context.rs  0% smaller
  crates/bevy_mod_scripting_core/src/script.rs  0% smaller
  crates/bevy_mod_scripting_core/src/script/context_key.rs  0% smaller
  crates/bevy_mod_scripting_core/src/script/mod.rs  0% smaller
  crates/bevy_mod_scripting_core/src/script/script_context.rs  0% smaller
  crates/lad_backends/mdbook_lad_preprocessor/src/sections.rs  0% smaller
  crates/testing_crates/script_integration_test_harness/Cargo.toml Unsupported file format
  crates/testing_crates/script_integration_test_harness/src/parse.rs  0% smaller
  crates/testing_crates/script_integration_test_harness/src/scenario.rs  0% smaller
  crates/testing_crates/test_utils/src/lib.rs  0% smaller
  docs/README.md Unsupported file format
  docs/src/ReleaseNotes/0.13-to-0.14.md Unsupported file format
  docs/src/ReleaseNotes/0.14-to-0.15.md Unsupported file format
  docs/src/ReleaseNotes/0.15.0.md Unsupported file format
  docs/src/ReleaseNotes/guides.md Unsupported file format
  docs/src/SUMMARY.md Unsupported file format
  docs/src/Summary/contexts.md Unsupported file format
  docs/src/Summary/customizing-script-contexts.md Unsupported file format
  docs/src/Summary/managing-scripts.md Unsupported file format
  docs/src/Summary/running-scripts.md Unsupported file format
  docs/src/Summary/script-id-mapping.md Unsupported file format
  docs/src/Summary/sharing-contexts-between-scripts.md Unsupported file format
  examples/docgen.rs  0% smaller
  examples/game_of_life.rs Unsupported file format
  examples/run-script.rs  0% smaller
  src/lib.rs  0% smaller
  src/prelude.rs  0% smaller

Copy link
Contributor

🐰 Bencher Report

Branchstaging
Testbedlinux-gha

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
component/access Lua📈 view plot
⚠️ NO THRESHOLD
3,546.00 ns
component/access Rhai📈 view plot
⚠️ NO THRESHOLD
5,890.60 ns
component/get Lua📈 view plot
⚠️ NO THRESHOLD
2,175.30 ns
component/get Rhai📈 view plot
⚠️ NO THRESHOLD
4,637.10 ns
conversions/Mut::from📈 view plot
⚠️ NO THRESHOLD
80.06 ns
conversions/Ref::from📈 view plot
⚠️ NO THRESHOLD
80.88 ns
conversions/ScriptValue::List📈 view plot
⚠️ NO THRESHOLD
312.48 ns
conversions/ScriptValue::Map📈 view plot
⚠️ NO THRESHOLD
1,236.30 ns
conversions/ScriptValue::Reference::from_into📈 view plot
⚠️ NO THRESHOLD
25.11 ns
conversions/Val::from_into📈 view plot
⚠️ NO THRESHOLD
251.14 ns
function/call 4 args Lua📈 view plot
⚠️ NO THRESHOLD
1,627.70 ns
function/call 4 args Rhai📈 view plot
⚠️ NO THRESHOLD
1,343.10 ns
function/call Lua📈 view plot
⚠️ NO THRESHOLD
230.26 ns
function/call Rhai📈 view plot
⚠️ NO THRESHOLD
388.54 ns
loading/empty Lua📈 view plot
⚠️ NO THRESHOLD
50,605.00 ns
loading/empty Rhai📈 view plot
⚠️ NO THRESHOLD
718,150.00 ns
math/vec mat ops Lua📈 view plot
⚠️ NO THRESHOLD
7,004.40 ns
math/vec mat ops Rhai📈 view plot
⚠️ NO THRESHOLD
6,024.40 ns
query/10 entities Lua📈 view plot
⚠️ NO THRESHOLD
19,101.00 ns
query/10 entities Rhai📈 view plot
⚠️ NO THRESHOLD
21,063.00 ns
query/100 entities Lua📈 view plot
⚠️ NO THRESHOLD
38,572.00 ns
query/100 entities Rhai📈 view plot
⚠️ NO THRESHOLD
33,038.00 ns
query/1000 entities Lua📈 view plot
⚠️ NO THRESHOLD
253,140.00 ns
query/1000 entities Rhai📈 view plot
⚠️ NO THRESHOLD
159,690.00 ns
reflection/10 Lua📈 view plot
⚠️ NO THRESHOLD
5,681.40 ns
reflection/10 Rhai📈 view plot
⚠️ NO THRESHOLD
15,288.00 ns
reflection/100 Lua📈 view plot
⚠️ NO THRESHOLD
47,763.00 ns
reflection/100 Rhai📈 view plot
⚠️ NO THRESHOLD
708,110.00 ns
resource/access Lua📈 view plot
⚠️ NO THRESHOLD
3,327.80 ns
resource/access Rhai📈 view plot
⚠️ NO THRESHOLD
5,353.00 ns
resource/get Lua📈 view plot
⚠️ NO THRESHOLD
1,875.20 ns
resource/get Rhai📈 view plot
⚠️ NO THRESHOLD
4,230.00 ns
🐰 View full continuous benchmarking report in Bencher

@makspll makspll changed the title feat: Use the Handles, Luke! (#427) feat!: Use the Handles, Luke! (#427) Aug 14, 2025
@makspll makspll enabled auto-merge (squash) August 14, 2025 22:03
@makspll makspll merged commit 48c7242 into main Aug 14, 2025
44 checks passed
@github-actions github-actions bot mentioned this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants