Use the same access mode of original file instead of fixed value #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue. After running the bspatch, the created file always has fixed access mode value (i.e. 0666) since this command does not consider the access mode. This patch uses the same access mode of the original file. Signed-off-by: Sangjung Woo <[email protected]>
|
Ping. Any comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The created file after running bspatch command always has the fixed access mode since the mode value is fixed as constant number (i.e 0666) in bspatch.c. IMO, it should be the same access mode of the original file.
This patch uses the same access mode of the original file instead of fixed value.