Skip to content

Use the same access mode of original file instead of fixed value #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2016

Conversation

again4you
Copy link
Contributor

The created file after running bspatch command always has the fixed access mode since the mode value is fixed as constant number (i.e 0666) in bspatch.c. IMO, it should be the same access mode of the original file.

This patch uses the same access mode of the original file instead of fixed value.

$ bsdiff/bsdiff hello hello2 delta.bsdiff
$ bsdiff/bspatch hello hello_new delta.bsdiff
$ ls -al hello_new hello
-rwxrwxr-x 1 again4you again4you 8551  4월  5 15:06 hello
-rwxrwxr-x 1 again4you again4you 8551  4월  6 18:33 hello_new

…alue.

After running the bspatch, the created file always has fixed access mode
value (i.e. 0666) since this command does not consider the access
mode. This patch uses the same access mode of the original file.

Signed-off-by: Sangjung Woo <[email protected]>
@again4you
Copy link
Contributor Author

Ping. Any comments?

@CoolOppo
Copy link
Contributor

@mendsley ?

@mendsley mendsley merged commit 7d70d8f into mendsley:master Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants