Use package.json exports for AutoImportProvider under `--moduleResolution node`

[OnkelTem]

Does this issue occur when all extensions are disabled?: Yes/No

• VS Code Version: 1.66.2
• OS Version: Linux Kubuntu 20.04

Steps to Reproduce:

1. npm init -y
2. npm i yargs
3. create a js file and type there: hideBin (it's a function from the yargs module)
4. then open the "Quick fix..." context menu
5. it doesn't contain an import suggestion

[mjbvz]

@andrewbranch hideBin only is picked up once I add an import for import { } from 'yargs/helpers';

Not sure if if this is a bug or expected

[andrewbranch]

Does it get suggested if you use "moduleResolution": "nodenext"?

This is expected. @types/yargs/index.d.ts has no mention of @types/yargs/helpers.d.ts so there’s no reason we would find it before it’s specifically requested. The typings could easily add a reference to it so this would work. However, the package.json exports does list "./helpers" and we should pick that up under nodenext via #47092. We could possibly run that logic even under the older moduleResolution modes, but it’s a little fishy and we would run the risk of picking up files we shouldn’t in packages that ship CJS and ESM side-by-side, for instance.

[andrewbranch]

Actually, I think under --moduleResolution node it would probably be alright to look at package.json exports for auto-importable files as long as we don’t include import in our conditions. This might be a nice experience improvement, but it may apply to relatively few packages for now.

[andrewbranch]

I’ll plan to investigate.

[OnkelTem]

Hi @andrewbranch!

The typings could easily add a reference to it so this would work.

How could they properly do that?