New option to remove spaces around braces: insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces

[dbaeumer]

From @aymone on July 8, 2016 17:59

• VSCode Version: 1.3
• OS Version: Ubuntu 16.04
• Language: JS

Steps to Reproduce:

1.Create a simple object with functions shorthand like:

const x = {
    a(){}
};

2.Use VSCode auto format (ctrl+shift+i):

const x = {
    a(){ } // why vscode add this extra space between braces?
};

Any way to disable this?

Copied from original issue: microsoft/vscode#8965

[dbaeumer]

Moving to TS team since the formatter comes from the tsserver.

[mhegazy]

This should be controled by insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets but looks like it is not being honored.

[saschanaz]

I think insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets is for 'brackets'.

https://github.com/Microsoft/TypeScript/blob/730f18955dc17068be33691f0fb0e0285ebbf9f5/tests/cases/fourslash/formattingOptionsChange.ts#L22 :

runTest("InsertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets", "[ 1 ];[];[];[ , ];", "[1];[];[];[,];");

Maybe a new option for braces is needed?

PS: Will the option finally make brace formatting rule consistent?

let ob = {}; // no space
interface A { }; // space

[aymone]

+1 New option for braces...

[alexanderby]

So, I'm using VSCode 1.8.1, I have the next workspace settings

{
     "javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": false
}

Still instead of

var x = {y: 5, z: 7};

I get this

var x = { y: 5, z: 7 };

Is this issue fixed?

[saschanaz]

Braces are not brackets and any new settings for this situation is not implemented yet. I'm not sure what should exactly be done there, will people want to incorporate rules for objects var a = {} and interfaces interface A { }?

Personally I do want to incorporate them and I really don't want to make two different rules to apply on those two different cases.

(The decision is not a super major factor for the delay, it's just that I had no time to visit here for months)