Skip to content

Fix out of index panic #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2024
Merged

Fix out of index panic #61

merged 3 commits into from
Feb 14, 2024

Conversation

ElisarEisenbach
Copy link
Contributor

@ElisarEisenbach ElisarEisenbach commented Jan 30, 2024 •
edited
Loading

  • when CurrentIndex == len(Responses)
    it means that if you will try to get responses[CurrentIndex] will make out of index panic.
    we are expecting to panic from here
  • fix typo reponse instead of response

@migueleliasweb
Copy link
Owner

Thanks for the contribution. I'll have a look today 👍.

migueleliasweb
migueleliasweb reviewed Feb 6, 2024
View reviewed changes
@migueleliasweb
Copy link
Owner

I'll have a look tonight. Thanks for the PR.

@migueleliasweb migueleliasweb merged commit c59fff9 into migueleliasweb:master Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueleliasweb migueleliasweb Awaiting requested review from migueleliasweb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElisarEisenbach @migueleliasweb