Skip to content

Remove automatic capability determination and add missing capabilities #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kfischer-okarin
Copy link
Contributor

This is effectively reverting my two previous PRs #8 #42 and adding the missing capabilities for list changed notifications.

See the Discussion linked in Motivation and context for details.

Motivation and Context

See Discussion #57 for background

How Has This Been Tested?

I tried it out in the inspector

Breaking Changes

Not really - for the same reasoning as already mentioned in #8

This should not be a breaking change since an empty tool list and no capability should make no practical difference to a procotol conform MCP client.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

The notification capabilities are not yet checked like the normal method capabilities - but that should be fixed in another PR I think (I will send that too later)

@kfischer-okarin kfischer-okarin changed the title Simplify capabilitiy handling and add missing capabilities Remove capability determination and add missing capabilities Jun 14, 2025
@kfischer-okarin kfischer-okarin changed the title Remove capability determination and add missing capabilities Remove automatic capability determination and add missing capabilities Jun 14, 2025
@kfischer-okarin kfischer-okarin force-pushed the simplify-and-add-missing-capabilities branch from 9658f59 to 2221470 Compare June 18, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant