CLOUDP-329787: Make Service Account transport available in httpClient() #4090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cveticm
commented
Aug 6, 2025
Comment on lines
-17
to
-21
| Public Preview: The atlas api sub-command, automatically generated from the MongoDB Atlas Admin API, offers full coverage of the Admin API and is currently in Public Preview (please provide feedback at https://feedback.mongodb.com/forums/930808-atlas-cli). | ||
| Admin API capabilities have their own release lifecycle, which you can check via the provided API endpoint documentation link. | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Out-of-date doc remnant after merge from master.
cveticm
commented
Aug 6, 2025
internal/cli/commonerrors/errors.go
Outdated
Comment on lines
69
to
70
| case "invalid_client": // oauth2 error | ||
| return ErrUnauthorized |
There was a problem hiding this comment.
if incorrect service account clientID or clientSecret is provided, we get an oauth2 error with error code "invalid_client"
To keep consistent behaviour as when incorrect credentials are provided for PAK and user account, we will listen out for this error and return ErrUnauthorized
There was a problem hiding this comment.
Could you turn invalid_client into a constant? (like the other entries)
cveticm
force-pushed
the
CLOUDP-329787_implement_SA
branch
from
0042311 to
4e26dfe
Compare
github-actions
bot
added
the
need-doc-review
|
APIx Bot |
: a message has been sent to Docs Slack channel 🚀.
cveticm
removed
the
need-doc-review
jeroenvervaeke
requested changes
Aug 6, 2025
internal/cli/commonerrors/errors.go
Outdated
Comment on lines
69
to
70
| case "invalid_client": // oauth2 error | ||
| return ErrUnauthorized |
There was a problem hiding this comment.
Could you turn invalid_client into a constant? (like the other entries)
github-actions
bot
added
the
need-doc-review
jeroenvervaeke
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
atlas auth whoamiFuture work
Jira ticket: CLOUDP-329787
Checklist
make fmtand formatted my code